[OS-BUILD PATCH] [redhat] New configs in security/keys

[GitLab Bridge on behalf of jeremycline]

From: Fedora Kernel Team

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

---

Signed-off-by: Fedora Kernel Team 
---
 redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS

diff --git a/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS b/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS
new file mode 100644
index 000000000000..e69de29bb2d1

[Prarit Bhargava]

On 6/14/20 6:45 PM, GitLab Bridge on behalf of jeremycline wrote:
> From: Fedora Kernel Team
>
> Hi,
>
> As part of the ongoing rebase effort, the following configuration
> options need to be reviewed.
>
> As a reminder, the ARK configuration flow involves moving unreviewed
> configuration options from the pending directory to the ark directory.
> In the diff below, options are removed from the pending directory and
> added to the ark hierarchy. The final options that need to be ACKed
> are the files that are being added to the ark hierarchy.
>
> If the value for a file that is added should be changed, please reply
> with a better option.
> Signed-off-by: Fedora Kernel Team
>
> redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS
>
> diff --git a/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS b/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS
> new file mode 100644
> index 000000000000..e69de29bb2d1

Something strange happened here?  Shouldn't there be more text on this?

In any case this should be enabled.

Nacked-by: Prarit Bhargava

P.

[OS-BUILD PATCHv2] [redhat] New configs in security/keys

[GitLab Bridge on behalf of jeremycline]

From: Fedora Kernel Team

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

CONFIG_KEY_NOTIFICATIONS

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

---

Signed-off-by: Fedora Kernel Team 
Signed-off-by: Patrick Talbert 
---
 .../common/generic/CONFIG_KEY_NOTIFICATIONS   |  1 +
 .../fedora/generic/CONFIG_KEY_NOTIFICATIONS   | 19 -------------------
 2 files changed, 1 insertion(+), 19 deletions(-)
 create mode 100644 redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS
 delete mode 100644 redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS

diff --git a/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS b/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS
new file mode 100644
index 000000000000..f6ce863cf65a
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS
@@ -0,0 +1 @@
+CONFIG_KEY_NOTIFICATIONS=y
diff --git a/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS b/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS
deleted file mode 100644
index f2556d44c1f0..000000000000
--- a/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS
+++ /dev/null
@@ -1,19 +0,0 @@
-# CONFIG_KEY_NOTIFICATIONS:
-# 
-# This option provides support for getting change notifications on keys
-# and keyrings on which the caller has View permission.  This makes use
-# of the /dev/watch_queue misc device to handle the notification
-# buffer and provides KEYCTL_WATCH_KEY to enable/disable watches.
-# 
-# Symbol: KEY_NOTIFICATIONS [=n]
-# Type  : bool
-# Defined at security/keys/Kconfig:118
-#   Prompt: Provide key/keyring change notifications
-#   Depends on: KEYS [=y] && WATCH_QUEUE [=y]
-#   Location:
-#     -> Security options
-#       -> Enable access key retention support (KEYS [=y])
-# 
-# 
-# 
-CONFIG_KEY_NOTIFICATIONS=y

[OS-BUILD PATCHv2] [redhat] New configs in security/keys

[GitLab Bridge on behalf of Patrick Talbert]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/464#note_47225329...

I pushed the requested changes. Can you review it again?

Thanks,

Patrick

[OS-BUILD PATCHv2] [redhat] New configs in security/keys

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/464#note_49405468...

This merge request has not been updated in over 30 days.
Please review this MR's current changes regarding the following
configuration option(s):

CONFIG_KEY_NOTIFICATIONS

[OS-BUILD PATCHv2] [redhat] New configs in security/keys

From: CKI Bot on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/464#note_49625429...

Acked-by: Prarit Bhargava 
(via approve button)

[OS-BUILD PATCHv3] [redhat] New configs in security/keys

[Jeremy Cline (via Email Bridge)]

From: Fedora Kernel Team

[redhat] New configs in security/keys

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

CONFIG_KEY_NOTIFICATIONS

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

---

Signed-off-by: Fedora Kernel Team 
Signed-off-by: Patrick Talbert

diff a/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS b/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_KEY_NOTIFICATIONS
@@ -0,0 +1 @@
+CONFIG_KEY_NOTIFICATIONS=y
diff a/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS b/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS
--- a/redhat/configs/fedora/generic/CONFIG_KEY_NOTIFICATIONS
+++ /dev/null
@@ -1,19 +0,0 @@
-# CONFIG_KEY_NOTIFICATIONS:
-# 
-# This option provides support for getting change notifications on keys
-# and keyrings on which the caller has View permission.  This makes use
-# of the /dev/watch_queue misc device to handle the notification
-# buffer and provides KEYCTL_WATCH_KEY to enable/disable watches.
-# 
-# Symbol: KEY_NOTIFICATIONS [=n]
-# Type  : bool
-# Defined at security/keys/Kconfig:118
-#   Prompt: Provide key/keyring change notifications
-#   Depends on: KEYS [=y] && WATCH_QUEUE [=y]
-#   Location:
-#     -> Security options
-#       -> Enable access key retention support (KEYS [=y])
-# 
-# 
-# 
-CONFIG_KEY_NOTIFICATIONS=y

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/464

[OS-BUILD PATCHv3] [redhat] New configs in security/keys

From: CKI Admin Bot on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/464#note_49924011...

Hi! This is the friendly CKI test bot.

It appears that you are not a member of redhat/red-hat-ci-
tools/kernel/cki-runs/trusted-pipelines. This means that the CI
pipeline on your MR will fail. As getting testing is important, I'll be
responsible for testing your changes. After every MR change, I'll start
a
small testing pipeline and link it here so you can follow the results.
I'll
also create and link a pipeline for hardware testing that the reviewers
can
start to get extra test coverage.

You can find more details about the contributor setup, permission issues
and
how to resolve them at
https://cki-project.org/docs/user_docs/gitlab-mr-testing/#trusted-and-
external-contributors

[OS-BUILD PATCHv3] [redhat] New configs in security/keys

From: CKI Admin Bot on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/464#note_49924017...

Testing pipeline status:
Basic testing pipeline:

  https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-
runs/external-pipelines/-/pipelines/250130508 - created
:hourglass_flowing_sand: