[PATCH] spec: add RHEL to the conditions to enable fancy_debug

[Aristeu Rozanski]

Strangely, with fancy_debug disabled, only ppc64 build breaks.

---
 kernel.spec |    3 +++
 1 file changed, 3 insertions(+)

--- a/kernel.spec	2009-06-08 12:32:07.000000000 -0400
+++ b/kernel.spec	2009-06-08 12:35:34.000000000 -0400
@@ -490,6 +490,9 @@ BuildConflicts: rhbuildsys(DiskFree) < 5
 %if 0%{?fedora} >= 8
 %define fancy_debuginfo 1
 %endif
+%if 0%{?rhel}
+%define fancy_debuginfo 1
+%endif
 %endif
 
 %if %{fancy_debuginfo}

[Don Zickus]

On Mon, Jun 08, 2009 at 02:39:27PM -0400, Aristeu Rozanski wrote:
>  Strangely, with fancy_debug disabled, only ppc64 build breaks.
How so?  Can I see the build output in brew?

Cheers,
Don

>  
>  ---
>   kernel.spec |    3 +++
>   1 file changed, 3 insertions(+)
>  
>  --- a/kernel.spec	2009-06-08 12:32:07.000000000 -0400
>  +++ b/kernel.spec	2009-06-08 12:35:34.000000000 -0400
>  @@ -490,6 +490,9 @@ BuildConflicts: rhbuildsys(DiskFree) < 5
>   %if 0%{?fedora} >= 8
>   %define fancy_debuginfo 1
>   %endif
>  +%if 0%{?rhel}
>  +%define fancy_debuginfo 1
>  +%endif
>   %endif
>   
>   %if %{fancy_debuginfo}
>  
>  _______________________________________________
>  Fedora-kernel-list mailing list
>  Fedora-kernel-list(a)redhat.com
>  https://www.redhat.com/mailman/listinfo/fedora-kernel-list

[Aristeu Rozanski]

>  On Mon, Jun 08, 2009 at 02:39:27PM -0400, Aristeu Rozanski wrote:
>  > Strangely, with fancy_debug disabled, only ppc64 build breaks.
>  
>  How so?  Can I see the build output in brew?
http://koji.fedoraproject.org/koji/getfile?taskID=1394994&name=build.log
this is F-11 kernel, only ppc64 build, forcing fancy_debuginfo = 0

-- 
Aristeu

[Don Zickus]

On Mon, Jun 08, 2009 at 03:32:41PM -0400, Aristeu Rozanski wrote:
>  > On Mon, Jun 08, 2009 at 02:39:27PM -0400, Aristeu Rozanski
> wrote:
>  > > Strangely, with fancy_debug disabled, only ppc64 build breaks.
>  > 
>  > How so?  Can I see the build output in brew?
>  http://koji.fedoraproject.org/koji/getfile?taskID=1394994&name=build.log
>  this is F-11 kernel, only ppc64 build, forcing fancy_debuginfo = 0 
Not suprisingly

%if !%{fancy_debuginfo}\
%if "%{elf_image_install_path}" != ""\
%{debuginfodir}/%{elf_image_install_path}/*-%{KVERREL}%{?2:.%{2}}.debug\
%endif\

is only executed when fancy_debuginfo is off and elf_image_install_path
is defined as

# This is %{image_install_path} on an arch where that includes ELF files,
# or empty otherwise.
%define elf_image_install_path %{?kernel_image_elf:%{image_install_path}}

And the only arch that defines 'kernel_image_elf' is ppc.  All the other
arches, the code up top is a no-op.

But, yeah your build is failing because it can't find
%{debuginfodir}/%{elf_image_install_path}/*-%{KVERREL}%{?2:.%{2}}.debug
files, which don't exist.  Not sure what the original intent of the code
up top was but it doesn't work.

Cheers,
Don