Re: rpms/kernel/devel kernel.spec,1.251,1.252 config-generic,1.42,1.43

[Dave Jones]

On Mon, Nov 26, 2007 at 07:37:34AM -0500, David Woodhouse wrote:
 
>  -# CONFIG_LIBERTAS is not set
>  -
>  +CONFIG_LIBERTAS=m
>  +CONFIG_LIBERTAS_USB=m
>  +CONFIG_LIBERTAS_CS=m
>  +CONFIG_LIBERTAS_SDIO=m
>  +CONFIG_LIBERTAS_DEBUG=y 
This is probably better placed in a per-arch override rather
than building it everywhere no?

	Dave

-- 
http://www.codemonkey.org.uk

rpms/kernel/devel kernel.spec,1.251,1.252 config-generic,1.42,1.43

[David Woodhouse]

On Mon, 2007-11-26 at 12:52 -0500, Dave Jones wrote:
>  On Mon, Nov 26, 2007 at 07:37:34AM -0500, David Woodhouse wrote:
>   
>   > -# CONFIG_LIBERTAS is not set
>   > -
>   > +CONFIG_LIBERTAS=m
>   > +CONFIG_LIBERTAS_USB=m
>   > +CONFIG_LIBERTAS_CS=m
>   > +CONFIG_LIBERTAS_SDIO=m
>   > +CONFIG_LIBERTAS_DEBUG=y
>  
>  This is probably better placed in a per-arch override rather
>  than building it everywhere no? 
Why? What arches would you exclude it on?

(please don't use tinfoil-hat address)

-- 
dwmw2

rpms/kernel/devel kernel.spec,1.251,1.252 config-generic,1.42,1.43

[Dave Jones]

On Mon, Nov 26, 2007 at 12:52:43PM -0500, Dave Jones wrote:
>  On Mon, Nov 26, 2007 at 07:37:34AM -0500, David Woodhouse wrote:
>   
>   > -# CONFIG_LIBERTAS is not set
>   > -
>   > +CONFIG_LIBERTAS=m
>   > +CONFIG_LIBERTAS_USB=m
>   > +CONFIG_LIBERTAS_CS=m
>   > +CONFIG_LIBERTAS_SDIO=m
>   > +CONFIG_LIBERTAS_DEBUG=y
>  
>  This is probably better placed in a per-arch override rather
>  than building it everywhere no? 
 
That's my point, do we /want/ to build it everywhere?
Is it likely to show up on ia64, sparc64, ppc64 etc etc?

	Dave

-- 
http://www.codemonkey.org.uk