[OS-BUILD PATCH] team: mark team driver as deprecated

[Hangbin Liu (via Email Bridge)]

From: Hangbin Liu <haliu(a)redhat.com&gt;

team: mark team driver as deprecated

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1945477
Upstream: RHEL only

We are planning to deprecate Teaming in RHEL 9 and remove it in RHEL 10.
Teaming and Bonding offer similar functionalities and are causing confusion
for our customers. In the past, Bonding was not keeping up-to-date and
hence Teaming was an option being pursued. Bonding now is keeping current
and also widely adopted by our customers. Hence, it makes sense to keep
Bonding as our preferred option going forward and avoid causing un-necessary
confusion.

Signed-off-by: Hangbin Liu <haliu(a)redhat.com&gt;

diff a/drivers/net/team/team.c b/drivers/net/team/team.c
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -3045,6 +3045,8 @@ static int __init team_module_init(void)
 	if (err)
 		goto err_nl_init;
 
+	mark_hardware_deprecated(DRV_NAME);
+
 	return 0;
 
 err_nl_init:

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063

[Long Xin (via Email Bridge)]

From: Long Xin on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5719...

@ptalbert I'm on the reviewer list, but I can't see the approve button
from my side, any idea why?

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5721...

Hmm at least at the moment you are not listed as a member of the project
so that is why you cannot use the Approve button. But in this case I
don't know how you were added as a Reviewer!

You can simply write a comment with your Ack or Nack and the bot will
pick it up.

[Justin Forbes (via Email Bridge)]

From: Justin Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5725...

The scripts that generate these requests also go through RHMAINTAINERS
and look for the proper reviewer. They are added via the Cc Lines in
the MR, and that is how they are added as reviewers even if not a
member of the project. I am not sure why it doesn't allow you to add
non members via the UI but it does work via Cc  lines.

[Long Xin (via Email Bridge)]

From: Long Xin on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5843...

Acked-by: Xin Long <lxin(a)redhat.com&gt;

[Hangbin Liu (via Email Bridge)]

From: Hangbin Liu on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5843...

@jmflinuxtx hi, Xin Long is the Maintainer of team, based on RHMAINTAINERS
doc.

[Justin Forbes (via Email Bridge)]

From: Justin Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5843...

Acked-by: Justin Forbes <jforbes(a)fedoraproject.org&gt;
(via approve button)

[Marcelo Ricardo Leitner (via Email Bridge)]

From: Marcelo Ricardo Leitner on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5843...

I have the same problem and approving via revumatic gave me a 403:
gitlab.exceptions.GitlabMRApprovalError: 403: 403 Forbidden

[Marcelo Ricardo Leitner (via Email Bridge)]

From: Marcelo Ricardo Leitner on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5843...

Acked-by: Marcelo Ricardo Leitner <mleitner(a)redhat.com&gt;

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1063#note_5844...

The kernel-ark project account supports a low fixed number of users. We
unfortunately cannot add everybody as a user and if you are not a user then GL
won't allow you to Approve an MR.

However, the ack_nack bot will still happily count your Acks if you leave then
as a comment!