[OS-BUILD PATCH] [redhat] New configs in lib/Kconfig.debug

[CKI ARK Bot (via Email Bridge)]

From: Fedora Kernel Team

[redhat] New configs in lib/Kconfig.debug

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

Symbol: DEBUG_VFS [=n]
 Type  : bool
 Defined at lib/Kconfig.debug:822
   Prompt: Debug VFS
   Depends on: DEBUG_KERNEL [=y]
   Location:
     -> Kernel hacking
       -> Memory Debugging
         -> Debug VFS (DEBUG_VFS [=n])

Commit: 8b17e540969a (vfs: add initial support for CONFIG_DEBUG_VFS)

---

Symbol: GCD_KUNIT_TEST [=m]
 Type  : tristate
 Defined at lib/Kconfig.debug:3248
   Prompt: Greatest common divisor test
   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
   Location:
     -> Kernel hacking
       -> Kernel Testing and Coverage
         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
           -> Greatest common divisor test (GCD_KUNIT_TEST [=m])

Commit: 9ab61886ac68 (lib/math: Add Kunit test suite for gcd())

---

Symbol: INT_LOG_KUNIT_TEST [=m]
 Type  : tristate
 Defined at lib/Kconfig.debug:3237
   Prompt: Integer log (int_log) test
   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
   Location:
     -> Kernel hacking
       -> Kernel Testing and Coverage
         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
           -> Integer log (int_log) test (INT_LOG_KUNIT_TEST [=m])

Commit: 84ec093f55f5 (lib/math: Add int_log test suite)

---

Symbol: INT_POW_KUNIT_TEST [=m]
 Type  : tristate
 Defined at lib/Kconfig.debug:3206
   Prompt: Integer exponentiation (int_pow) test
   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
   Location:
     -> Kernel hacking
       -> Kernel Testing and Coverage
         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
           -> Integer exponentiation (int_pow) test (INT_POW_KUNIT_TEST [=m])

Commit: 3e50ba8fc834 (lib: math: Move KUnit tests into tests/ subdir)

---

Symbol: KFIFO_KUNIT_TEST [=m]
 Type  : tristate
 Defined at lib/Kconfig.debug:2717
   Prompt: KUnit Test for the generic kernel FIFO implementation
   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
   Location:
     -> Kernel hacking
       -> Kernel Testing and Coverage
         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
           -> KUnit Test for the generic kernel FIFO implementation (KFIFO_KUNIT_TEST [=m])

Commit: 4d557cb49986 (lib/tests/kfifo_kunit.c: add tests for the kfifo structure)

---

Symbol: OBJTOOL_WERROR [=n]
 Type  : bool
 Defined at lib/Kconfig.debug:548
   Prompt: Upgrade objtool warnings to errors
   Depends on: OBJTOOL [=y] && !COMPILE_TEST [=n]
   Location:
     -> Kernel hacking
       -> Compile-time checks and compiler options
         -> Upgrade objtool warnings to errors (OBJTOOL_WERROR [=n])

Commit: 36799069b481 (objtool: Add CONFIG_OBJTOOL_WERROR)

---

Symbol: PRIME_NUMBERS_KUNIT_TEST [=m]
 Type  : tristate
 Defined at lib/Kconfig.debug:3261
   Prompt: Prime number generator test
   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
   Location:
     -> Kernel hacking
       -> Kernel Testing and Coverage
         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
           -> Prime number generator test (PRIME_NUMBERS_KUNIT_TEST [=m])
 Selects: PRIME_NUMBERS [=m]

Commit: 313b38a6ecb4 (lib/prime_numbers: convert self-test to KUnit)

---

Symbol: PRINTF_KUNIT_TEST [=m]
 Type  : tristate
 Defined at lib/Kconfig.debug:2441
   Prompt: KUnit test printf() family of functions at runtime
   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
   Location:
     -> Kernel hacking
       -> Kernel Testing and Coverage
         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
           -> KUnit test printf() family of functions at runtime (PRINTF_KUNIT_TEST [=m])

Commit: 7a79e7daa84e (printf: convert self-test to KUnit)

---

Symbol: SCANF_KUNIT_TEST [=m]
 Type  : tristate
 Defined at lib/Kconfig.debug:2450
   Prompt: KUnit test scanf() family of functions at runtime
   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
   Location:
     -> Kernel hacking
       -> Kernel Testing and Coverage
         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
           -> KUnit test scanf() family of functions at runtime (SCANF_KUNIT_TEST [=m])

Commit: 97c1f302f2bc (scanf: convert self-test to KUnit)

---

Signed-off-by: Fedora Kernel Team

diff --git a/redhat/configs/pending-rhel/generic/CONFIG_DEBUG_VFS b/redhat/configs/pending-rhel/generic/CONFIG_DEBUG_VFS
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_DEBUG_VFS
+++ /dev/null
@@ -1,14 +0,0 @@
-# Symbol: DEBUG_VFS [=n]
-# Type  : bool
-# Defined at lib/Kconfig.debug:822
-#   Prompt: Debug VFS
-#   Depends on: DEBUG_KERNEL [=y]
-#   Location:
-#     -> Kernel hacking
-#       -> Memory Debugging
-#         -> Debug VFS (DEBUG_VFS [=n])
-# 
-# 
-# 
-# Commit: 8b17e540969a (vfs: add initial support for CONFIG_DEBUG_VFS)
-# CONFIG_DEBUG_VFS is not set
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_GCD_KUNIT_TEST b/redhat/configs/pending-rhel/generic/CONFIG_GCD_KUNIT_TEST
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_GCD_KUNIT_TEST
+++ /dev/null
@@ -1,16 +0,0 @@
-# Symbol: GCD_KUNIT_TEST [=m]
-# Type  : tristate
-# Defined at lib/Kconfig.debug:3248
-#   Prompt: Greatest common divisor test
-#   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
-#   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
-#   Location:
-#     -> Kernel hacking
-#       -> Kernel Testing and Coverage
-#         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
-#           -> Greatest common divisor test (GCD_KUNIT_TEST [=m])
-# 
-# 
-# 
-# Commit: 9ab61886ac68 (lib/math: Add Kunit test suite for gcd())
-CONFIG_GCD_KUNIT_TEST=m
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_INT_LOG_KUNIT_TEST b/redhat/configs/pending-rhel/generic/CONFIG_INT_LOG_KUNIT_TEST
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_INT_LOG_KUNIT_TEST
+++ /dev/null
@@ -1,16 +0,0 @@
-# Symbol: INT_LOG_KUNIT_TEST [=m]
-# Type  : tristate
-# Defined at lib/Kconfig.debug:3237
-#   Prompt: Integer log (int_log) test
-#   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
-#   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
-#   Location:
-#     -> Kernel hacking
-#       -> Kernel Testing and Coverage
-#         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
-#           -> Integer log (int_log) test (INT_LOG_KUNIT_TEST [=m])
-# 
-# 
-# 
-# Commit: 84ec093f55f5 (lib/math: Add int_log test suite)
-CONFIG_INT_LOG_KUNIT_TEST=m
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_INT_POW_KUNIT_TEST b/redhat/configs/pending-rhel/generic/CONFIG_INT_POW_KUNIT_TEST
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_INT_POW_KUNIT_TEST
+++ /dev/null
@@ -1,16 +0,0 @@
-# Symbol: INT_POW_KUNIT_TEST [=m]
-# Type  : tristate
-# Defined at lib/Kconfig.debug:3206
-#   Prompt: Integer exponentiation (int_pow) test
-#   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
-#   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
-#   Location:
-#     -> Kernel hacking
-#       -> Kernel Testing and Coverage
-#         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
-#           -> Integer exponentiation (int_pow) test (INT_POW_KUNIT_TEST [=m])
-# 
-# 
-# 
-# Commit: 3e50ba8fc834 (lib: math: Move KUnit tests into tests/ subdir)
-CONFIG_INT_POW_KUNIT_TEST=m
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_KFIFO_KUNIT_TEST b/redhat/configs/pending-rhel/generic/CONFIG_KFIFO_KUNIT_TEST
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_KFIFO_KUNIT_TEST
+++ /dev/null
@@ -1,16 +0,0 @@
-# Symbol: KFIFO_KUNIT_TEST [=m]
-# Type  : tristate
-# Defined at lib/Kconfig.debug:2717
-#   Prompt: KUnit Test for the generic kernel FIFO implementation
-#   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
-#   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
-#   Location:
-#     -> Kernel hacking
-#       -> Kernel Testing and Coverage
-#         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
-#           -> KUnit Test for the generic kernel FIFO implementation (KFIFO_KUNIT_TEST [=m])
-# 
-# 
-# 
-# Commit: 4d557cb49986 (lib/tests/kfifo_kunit.c: add tests for the kfifo structure)
-CONFIG_KFIFO_KUNIT_TEST=m
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_OBJTOOL_WERROR b/redhat/configs/pending-rhel/generic/CONFIG_OBJTOOL_WERROR
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_OBJTOOL_WERROR
+++ /dev/null
@@ -1,14 +0,0 @@
-# Symbol: OBJTOOL_WERROR [=n]
-# Type  : bool
-# Defined at lib/Kconfig.debug:548
-#   Prompt: Upgrade objtool warnings to errors
-#   Depends on: OBJTOOL [=y] && !COMPILE_TEST [=n]
-#   Location:
-#     -> Kernel hacking
-#       -> Compile-time checks and compiler options
-#         -> Upgrade objtool warnings to errors (OBJTOOL_WERROR [=n])
-# 
-# 
-# 
-# Commit: 36799069b481 (objtool: Add CONFIG_OBJTOOL_WERROR)
-# CONFIG_OBJTOOL_WERROR is not set
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_PRIME_NUMBERS_KUNIT_TEST b/redhat/configs/pending-rhel/generic/CONFIG_PRIME_NUMBERS_KUNIT_TEST
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_PRIME_NUMBERS_KUNIT_TEST
+++ /dev/null
@@ -1,17 +0,0 @@
-# Symbol: PRIME_NUMBERS_KUNIT_TEST [=m]
-# Type  : tristate
-# Defined at lib/Kconfig.debug:3261
-#   Prompt: Prime number generator test
-#   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
-#   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
-#   Location:
-#     -> Kernel hacking
-#       -> Kernel Testing and Coverage
-#         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
-#           -> Prime number generator test (PRIME_NUMBERS_KUNIT_TEST [=m])
-# Selects: PRIME_NUMBERS [=m]
-# 
-# 
-# 
-# Commit: 313b38a6ecb4 (lib/prime_numbers: convert self-test to KUnit)
-CONFIG_PRIME_NUMBERS_KUNIT_TEST=m
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_PRINTF_KUNIT_TEST b/redhat/configs/pending-rhel/generic/CONFIG_PRINTF_KUNIT_TEST
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_PRINTF_KUNIT_TEST
+++ /dev/null
@@ -1,16 +0,0 @@
-# Symbol: PRINTF_KUNIT_TEST [=m]
-# Type  : tristate
-# Defined at lib/Kconfig.debug:2441
-#   Prompt: KUnit test printf() family of functions at runtime
-#   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
-#   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
-#   Location:
-#     -> Kernel hacking
-#       -> Kernel Testing and Coverage
-#         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
-#           -> KUnit test printf() family of functions at runtime (PRINTF_KUNIT_TEST [=m])
-# 
-# 
-# 
-# Commit: 7a79e7daa84e (printf: convert self-test to KUnit)
-CONFIG_PRINTF_KUNIT_TEST=m
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_SCANF_KUNIT_TEST b/redhat/configs/pending-rhel/generic/CONFIG_SCANF_KUNIT_TEST
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/configs/pending-rhel/generic/CONFIG_SCANF_KUNIT_TEST
+++ /dev/null
@@ -1,16 +0,0 @@
-# Symbol: SCANF_KUNIT_TEST [=m]
-# Type  : tristate
-# Defined at lib/Kconfig.debug:2450
-#   Prompt: KUnit test scanf() family of functions at runtime
-#   Depends on: RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
-#   Visible if: RUNTIME_TESTING_MENU [=y] && KUNIT [=m] && !KUNIT_ALL_TESTS [=m]
-#   Location:
-#     -> Kernel hacking
-#       -> Kernel Testing and Coverage
-#         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
-#           -> KUnit test scanf() family of functions at runtime (SCANF_KUNIT_TEST [=m])
-# 
-# 
-# 
-# Commit: 97c1f302f2bc (scanf: convert self-test to KUnit)
-CONFIG_SCANF_KUNIT_TEST=m
diff --git a/redhat/configs/rhel/generic/CONFIG_DEBUG_VFS b/redhat/configs/rhel/generic/CONFIG_DEBUG_VFS
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_DEBUG_VFS
@@ -0,0 +1 @@
+# CONFIG_DEBUG_VFS is not set
diff --git a/redhat/configs/rhel/generic/CONFIG_GCD_KUNIT_TEST b/redhat/configs/rhel/generic/CONFIG_GCD_KUNIT_TEST
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_GCD_KUNIT_TEST
@@ -0,0 +1 @@
+CONFIG_GCD_KUNIT_TEST=m
diff --git a/redhat/configs/rhel/generic/CONFIG_INT_LOG_KUNIT_TEST b/redhat/configs/rhel/generic/CONFIG_INT_LOG_KUNIT_TEST
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_INT_LOG_KUNIT_TEST
@@ -0,0 +1 @@
+CONFIG_INT_LOG_KUNIT_TEST=m
diff --git a/redhat/configs/rhel/generic/CONFIG_INT_POW_KUNIT_TEST b/redhat/configs/rhel/generic/CONFIG_INT_POW_KUNIT_TEST
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_INT_POW_KUNIT_TEST
@@ -0,0 +1 @@
+CONFIG_INT_POW_KUNIT_TEST=m
diff --git a/redhat/configs/rhel/generic/CONFIG_KFIFO_KUNIT_TEST b/redhat/configs/rhel/generic/CONFIG_KFIFO_KUNIT_TEST
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_KFIFO_KUNIT_TEST
@@ -0,0 +1 @@
+CONFIG_KFIFO_KUNIT_TEST=m
diff --git a/redhat/configs/rhel/generic/CONFIG_OBJTOOL_WERROR b/redhat/configs/rhel/generic/CONFIG_OBJTOOL_WERROR
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_OBJTOOL_WERROR
@@ -0,0 +1 @@
+# CONFIG_OBJTOOL_WERROR is not set
diff --git a/redhat/configs/rhel/generic/CONFIG_PRIME_NUMBERS_KUNIT_TEST b/redhat/configs/rhel/generic/CONFIG_PRIME_NUMBERS_KUNIT_TEST
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_PRIME_NUMBERS_KUNIT_TEST
@@ -0,0 +1 @@
+CONFIG_PRIME_NUMBERS_KUNIT_TEST=m
diff --git a/redhat/configs/rhel/generic/CONFIG_PRINTF_KUNIT_TEST b/redhat/configs/rhel/generic/CONFIG_PRINTF_KUNIT_TEST
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_PRINTF_KUNIT_TEST
@@ -0,0 +1 @@
+CONFIG_PRINTF_KUNIT_TEST=m
diff --git a/redhat/configs/rhel/generic/CONFIG_SCANF_KUNIT_TEST b/redhat/configs/rhel/generic/CONFIG_SCANF_KUNIT_TEST
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/rhel/generic/CONFIG_SCANF_KUNIT_TEST
@@ -0,0 +1 @@
+CONFIG_SCANF_KUNIT_TEST=m

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750

[Joe Lawrence (via Email Bridge)]

From: Joe Lawrence on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2417843...

We (@jpoimboe, @rysulliv) would like to turn on CONFIG_OBJTOOL_WERROR for
supported arches (x86_64, ppc64le).  What is the process to do that?  Does
someone address it here in the new config review, or do we open a new MR for
that specific option later?  Thanks.

[Scott Weaver (via Email Bridge)]

From: Scott Weaver on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2417867...

Either @ptalbert or I can update the MR for you.

[Joe Lawrence (via Email Bridge)]

From: Joe Lawrence on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2418075...

That would be great, thanks guys!

[Joe Lawrence (via Email Bridge)]

From: Joe Lawrence on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2417843...

We (@jpoimboe, @rysulliv) would like to turn on CONFIG_OBJTOOL_WERROR for
supported arches (x86_64, ppc64le) for Fedora and RHEL (9 and 10, we can
handle the RHEL backports).  What is the process to do that?  Does someone
address it here in the new config review, or do we open a new MR for that
specific option later?  Thanks.

[Joe Lawrence (via Email Bridge)]

From: Joe Lawrence on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2420026...

Actually, we should probably ping @jstancek and @jmflinuxtx on this.  If we
promote objtool warnings to build errors, do we want this in Fedora and/or
RHEL considering it may also affect third-party OOT module builds (I assume).
Objtool complaints should ideally be fixed as can turn into real bugs, but I
suppose the same argument could be made for CONFIG_WERROR.

[Jan Stancek (via Email Bridge)]

From: Jan Stancek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2420057...

We have a variable in Makefile.variables for WERROR, it's off for Fedora due
to rate of changes that introduce warnings. And it does look like we forgot to
enable it for c10s.

[Joe Lawrence (via Email Bridge)]

From: Joe Lawrence on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2420419...

@jstancek : for the uninitiated, what's the reason for the WERROR variable and
not a path based entry like other CONFIG_* entries?

[Jan Stancek (via Email Bridge)]

From: Jan Stancek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2420672...

I think it's there just to make it easier to switch for downstream distros.
@hertonrk-rh Do you recall more details about this variable?

[Herton R. Krzesinski (via Email Bridge)]

From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2420734...

No, but I remember the same thing, it's to easily switch off for
downstream/Fedora.

[Prarit Bhargava (via Email Bridge)]

From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2420762...

@joe.lawrence I remember what happened.  Linus introduced this and then other
developers immediately started reporting issues.  Every new gcc release
results in new warnings being issued.  Since different developers are using
different versions of gcc, you can imagine the reports Linus received.

So that's why this switch is odd.  FWIW we should have it on in RHEL (which
IIRC we do) and off in Fedora (which we do).  If it is off in c10s, that
should be reported as a bug and it should be turned on.  There is no reason
that the modified RHEL kernel should compile with warnings.

[Jan Stancek (via Email Bridge)]

From: Jan Stancek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2420814...

I've opened draft Mr for c10s to see what's missing for clean build.

[Jan Stancek (via Email Bridge)]

From: Jan Stancek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2420814...

I've opened draft Mr for c10s to see what's missing for clean build. Will open
issue too.

[Jan Stancek (via Email Bridge)]

From: Jan Stancek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2422446...

C10S issue: https://issues.redhat.com/browse/RHEL-85334

[Joe Lawrence (via Email Bridge)]

From: Joe Lawrence on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3750#note_2426714...

Ok from kernel-ark mtg, we decided to implement this simliarly to WERROR, so
no kernel-ark change needed.  (We'll turn on for RHEL behind a similar
variable, off for all other releases.)