[PATCH]

[Yuta Kobayashi]

This patch provides definition of Microsoft Type Cover Pro 4 (JP).

---
 drivers/hid/hid-core.c          | 2 ++
 drivers/hid/hid-ids.h           | 1 +
 drivers/hid/hid-microsoft.c     | 2 ++
 drivers/hid/usbhid/hid-quirks.c | 1 +
 4 files changed, 6 insertions(+)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 4f9c5c6..98f752a 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -727,6 +727,7 @@ static void hid_scan_collection(struct hid_parser *parser, unsigned
type)
 	    (hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 ||
 	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 ||
 	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP ||
+	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP ||
 	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 ||
 	     hid->product == USB_DEVICE_ID_MS_POWER_COVER) &&
 	    hid->group == HID_GROUP_MULTITOUCH)
@@ -1978,6 +1979,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_DIGITAL_MEDIA_7K) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_DIGITAL_MEDIA_600) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 0238f01..7b725d6 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -695,6 +695,7 @@
 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3    0x07dc
 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2  0x07e2
 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd
+#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP 0x07e9
 #define USB_DEVICE_ID_MS_TYPE_COVER_3    0x07de
 #define USB_DEVICE_ID_MS_POWER_COVER     0x07da
 
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index e924d55..56c586f 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -288,6 +288,8 @@ static const struct hid_device_id ms_devices[] = {
 		.driver_data = MS_HIDINPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP),
 		.driver_data = MS_HIDINPUT },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP),
+		.driver_data = MS_HIDINPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3),
 		.driver_data = MS_HIDINPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER),
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 53fc856..7f4cecd 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -93,6 +93,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS
},
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2,
HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP,
HID_QUIRK_NO_INIT_REPORTS },
+	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP,
HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS },
-- 
2.5.5

[Laura Abbott]

On 08/09/2016 06:25 PM, Yuta Kobayashi wrote:
>  This patch provides definition of Microsoft Type Cover Pro 4 (JP).
>  
The patch looks fine but it needs to be submitted to the upstream
maintainers before it goes into Fedora. Try running your patch
through scripts/get_maintainer.pl in the kernel directory to
get a list of maintainers to send the patch to.

Please also remember to add your Signed-off-by [1] along with a
proper subject and commit text[2].

Thanks,
Laura

[1]https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Do...
[2]https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Do...

>  ---
>   drivers/hid/hid-core.c          | 2 ++
>   drivers/hid/hid-ids.h           | 1 +
>   drivers/hid/hid-microsoft.c     | 2 ++
>   drivers/hid/usbhid/hid-quirks.c | 1 +
>   4 files changed, 6 insertions(+)
>
>  diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>  index 4f9c5c6..98f752a 100644
>  --- a/drivers/hid/hid-core.c
>  +++ b/drivers/hid/hid-core.c
>  @@ -727,6 +727,7 @@ static void hid_scan_collection(struct hid_parser *parser, unsigned
> type)
>   	    (hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 ||
>   	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 ||
>   	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP ||
>  +	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP ||
>   	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 ||
>   	     hid->product == USB_DEVICE_ID_MS_POWER_COVER) &&
>   	    hid->group == HID_GROUP_MULTITOUCH)
>  @@ -1978,6 +1979,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) },
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2) },
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
>  +	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP) },
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3) },
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_DIGITAL_MEDIA_7K) },
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_DIGITAL_MEDIA_600) },
>  diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>  index 0238f01..7b725d6 100644
>  --- a/drivers/hid/hid-ids.h
>  +++ b/drivers/hid/hid-ids.h
>  @@ -695,6 +695,7 @@
>   #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3    0x07dc
>   #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2  0x07e2
>   #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd
>  +#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP 0x07e9
>   #define USB_DEVICE_ID_MS_TYPE_COVER_3    0x07de
>   #define USB_DEVICE_ID_MS_POWER_COVER     0x07da
>
>  diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
>  index e924d55..56c586f 100644
>  --- a/drivers/hid/hid-microsoft.c
>  +++ b/drivers/hid/hid-microsoft.c
>  @@ -288,6 +288,8 @@ static const struct hid_device_id ms_devices[] = {
>   		.driver_data = MS_HIDINPUT },
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP),
>   		.driver_data = MS_HIDINPUT },
>  +	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP),
>  +		.driver_data = MS_HIDINPUT },
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3),
>   		.driver_data = MS_HIDINPUT },
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER),
>  diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
>  index 53fc856..7f4cecd 100644
>  --- a/drivers/hid/usbhid/hid-quirks.c
>  +++ b/drivers/hid/usbhid/hid-quirks.c
>  @@ -93,6 +93,7 @@ static const struct hid_blacklist {
>   	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS
> },
>   	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2,
> HID_QUIRK_NO_INIT_REPORTS },
>   	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP,
> HID_QUIRK_NO_INIT_REPORTS },
>  +	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP,
> HID_QUIRK_NO_INIT_REPORTS },
>   	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS },
>   	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, HID_QUIRK_NO_INIT_REPORTS },
>   	{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS },
>

[Yuta Kobayashi]

Thank you so much to advices!

I'll try send patch to maintainers along your advices!

[Dennis Chen]

Sorry if this might be a little late, but there's already a bit of work
going on in this field upstream, which might be helpful.

Checkout this thread: https://patchwork.kernel.org/patch/9184979/

Sincerely,
Dennis Chen

[Yuta Kobayashi]

Hi.

My patches were merged at linux-next.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?...

When will this patch be possible to merge to fedora kernel?

A. Fedora 25 (whith kernel 4.8) coming
B. kernel 4.8 (not RC) coming
C. now
D. something else

[Justin Forbes]

That is an isolated patch, simple change and in next. I see no problem with
adding it to today's builds for rawhide and f25.

Thanks,
Justin

On Tue, Aug 23, 2016 at 6:40 PM, Yuta Kobayashi <alu(a)fedoraproject.org&gt;
wrote:

>  Hi.
>
>  My patches were merged at linux-next.
>  https://git.kernel.org/cgit/linux/kernel/git/next/linux-
>  next.git/commit/?id=b490a8537df60d449199e162417da74ee9262515
>
>  When will this patch be possible to merge to fedora kernel?
>
>  A. Fedora 25 (whith kernel 4.8) coming
>  B. kernel 4.8 (not RC) coming
>  C. now
>  D. something else
>  _______________________________________________
>  kernel mailing list
>  kernel(a)lists.fedoraproject.org
>  https://lists.fedoraproject.org/admin/lists/[e-mail]
>

[Yuta Kobayashi]

Thank you for reply.

What should i do for merge?

[Justin Forbes]

On Sun, Aug 28, 2016 at 7:38 PM, Yuta Kobayashi <alu(a)fedoraproject.org&gt; wrote:
>  Thank you for reply.
>
>  What should i do for merge? 
Nothing that you need to do, it is in the current rawhide kernels, and
latest f25 builds.

Justin