Hi, Pratyush
Thanks for the review..
On 12/04/15 at 05:06pm, Pratyush Anand wrote:
On 30/11/2015:05:40:59 PM, dyoung(a)redhat.com wrote:
> For arches we do not exlictly support, kdumpctl will fail with errors because
explicitly
> kernel can not be found. It is caused by there's no proper KDUMP_IMG prefix
> so kernel image can not be found.
>
> Kexec/kdump functionality may simply work, so let's add those prefix in
> default sysconfig file thus one can test and use kexec/kdump in Fedora.
>
> Signed-off-by: Dave Young <dyoung(a)redhat.com>
> ---
> kdump.sysconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- kexec-tools.orig/kdump.sysconfig
> +++ kexec-tools/kdump.sysconfig
> @@ -24,3 +24,9 @@ KDUMP_COMMANDLINE_APPEND="irqpoll maxcpu
> # Example:
> # KEXEC_ARGS="--elf32-core-headers"
> KEXEC_ARGS=""
> +
> +#Where to find the boot image
> +#KDUMP_BOOTDIR="/boot"
> +
> +#What is the image type used for kdump
> +KDUMP_IMG="vmlinuz"
Now, probably we can also remove these defines from arch specific sysconfig.
Yes, it is reasonable to move the to kdumpctl, but let's fix it first.
We can discuss and improve it later.
Reviewed-by: Pratyush Anand <panand(a)redhat.com>
_______________________________________________
kexec mailing list
kexec(a)lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/kexec@lists.fedoraproject.org
Thanks
Dave