On 03/28/2017 at 06:01 PM, Xunlei Pang wrote:
On 03/28/2017 at 03:55 PM, Dave Young wrote:
> On 03/27/17 at 10:42am, Xunlei Pang wrote:
>> v1->v2:
>> Add the hook in kdumpctl, so we use this hook anywhere, this helps a loot
>> for the "all_root" checklist(see PATCH4).
>>
>> We add a generic dump target hook for kdump, supposed to monitor all the
>> devices mounted by kdump.
>>
>> PATCH2 implements the basic framework, add a hook kdump_target_hook(),
>> and provide a generic helper kdump_targets_tell() for use.
> Xunlei, I personally like the v1 more, since it is easier to understand.
>
> Dropping root parameter is simple. For changing lvm parameter as
> we discussed we do not need to consider linear or not, so we can just
> change the lvm.conf if it exists in 2nd kernel /etc/ unconditionally.
Yes, thanks, PATCH6 can be independent now, I already updated it to be the following
implementation since we don't need to judge the linear lvm, I did it unconditionally
and ignored the error by using &>/dev/null:
Hi Dave,
I've sent this update out separately, please help review it, so that we can focus on
the remaining
"remove root=X" issue from now on. Thanks!
Regards,
Xunlei
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index 1f96bb8..674f3ee 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -743,4 +743,9 @@ install() {
# target. Ideally all this should be pushed into dracut iscsi module
# at some point of time.
kdump_check_iscsi_targets
+
+ # For the lvm type target under kdump, in /etc/lvm/lvm.conf we can safely replace
+ # "reserved_memory = 8192" with "reserved_memory = 1024" to
lower memory pressure
+ sed -i -e
's/\(^[[:space:]]*\)reserved_memory[[:space:]]*=[[:space:]]*[[:digit:]]*/ \
+ \1reserved_memory = 1024/' ${initdir}/etc/lvm/lvm.conf
&>/dev/null
}
Regards,
Xunlei