On Thu, Mar 18, 2021 at 04:13:42PM +0800, Kairui Song wrote:
On Thu, Feb 25, 2021 at 6:02 PM Coiby Xu <coxu(a)redhat.com>
wrote:
>
> dracut will build the PRMs which will be installed onto the image to run
> the tests.
>
> Signed-off-by: Coiby Xu <coxu(a)redhat.com>
> ---
> tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 71b329b..3403e6f 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -74,7 +74,7 @@ $(TEST_ROOT)/output/test-base-image: $(BUILD_ROOT)/inst-base-image
$(KEXEC_TOOLS
> $(BUILD_ROOT)/inst-base-image \
> $(TEST_ROOT)/output/test-base-image \
> $(TEST_ROOT)/scripts/build-scripts/test-base-image.sh \
> - $(KEXEC_TOOLS_RPM)
> + $(KEXEC_TOOLS_RPM) $(DRACUT_RPMs)
Looks good, just two suggestion: 1. Keep the whole variable name
capitalized 2. Can we use a more generic name, like EXTRA_RPMS, so if
we want to install something else, we can keep reusing this variable.
Thanks! I've applied your suggestions in v2.
>
> test-run: $(TEST_ROOT)/output/test-base-image
> ifeq ($(strip $(TEST_CASE)),)
> --
> 2.30.1
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
> Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
--
Best Regards,
Kairui Song
--
Best regards,
Coiby