Re: [PATCH] kdump-lib.sh: Fix is_user_configured_dump_target()

[Kairui Song]

Thanks for the patch, looks good to me.

On Tue, Feb 25, 2020 at 1:13 AM HAGIO KAZUHITO(萩尾　一仁)
<k-hagio-ab(a)nec.com&gt; wrote:
>  Currently, is_user_configured_dump_target() doesn't work as expected
>  due to lack of grep -E option.
>
>  As a result, kdump service with a ssh dump configuration can unnecessarily
>  fail to start due to the non-existence of a directory at where the path
>  option specifies on the local system:
>
>    kdumpctl[9760]: Rebuilding /boot/initramfs-5.4.19-200.fc31.x86_64kdump.img
>    kdumpctl[9760]: Dump path /var/crash/ssh does not exist.
>    kdumpctl[9760]: mkdumprd: failed to make kdump initrd
>    kdumpctl[9760]: Starting kdump: [FAILED]
>
>  Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com&gt;
>  ---
>   kdump-lib.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>  diff --git a/kdump-lib.sh b/kdump-lib.sh
>  index 2428b5d..9c41439 100755
>  --- a/kdump-lib.sh
>  +++ b/kdump-lib.sh
>  @@ -117,7 +117,7 @@ to_dev_name() {
>
>   is_user_configured_dump_target()
>   {
>  -    grep -q "^ext[234]|^xfs|^btrfs|^minix|^raw|^nfs|^ssh" /etc/kdump.conf ||
> is_mount_in_dracut_args;
>  +    grep -E -q "^ext[234]|^xfs|^btrfs|^minix|^raw|^nfs|^ssh" /etc/kdump.conf
> || is_mount_in_dracut_args;
>   }
>
>   get_user_configured_dump_disk()
>  --
>  2.24.1
>  _______________________________________________
>  kexec mailing list -- kexec(a)lists.fedoraproject.org
>  To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail] 


-- 
Best Regards,
Kairui Song