Re: [PATCH v6 1/2] Introduce kdump error handling service

[Vivek Goyal]

On Thu, Jul 31, 2014 at 02:30:09PM +0800, WANG Chao wrote:

[..]
> --- /dev/null
> +++ b/dracut-kdump-error-handler.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh
>
> +. /lib/kdump-lib-initramfs.sh
>
> +set -o pipefail
> +export PATH=$PATH:$KDUMP_SCRIPT_DIR
>
> +# We only allow to enter kdump error handler once.
> +# If error happens in error handling path and we simply reboot.
> +if [ -f /kdump-error-handler ]; then
> do_final_action

Why are we rebooting here. Why not simply return and exit and other
instance of error handler will face error and reboot system?
> +else
> > /kdump-error-handler
>
> +fi

how about calling this file as kdump-error-handler-running. So that we
nobody confuses it with actual error handler.

Thanks
Vivek