On 10/19/15 at 03:16pm, Dangyi Liu wrote:
On Mon, 2015-10-19 at 14:52 +0800, Dave Young wrote:
>
> How about remove them only for /proc/cmdline like below:
> and fix the comment in sysconfig to mentione it is only for removing
> from /proc/cmdline.
>
> if [ -z "$KDUMP_COMMANDLINE" ]; then
> cmdline=`cat /proc/cmdline`
> remove_cmdline_param ${KDUMP_COMMANDLINE_REMOVE}
> else
> cmdline=${KDUMP_COMMANDLINE}
> fi
I think removing KDUMP_COMMANDLINE_REMOVE regardless of where cmdline
comes from is more consistent with KDUMP_COMMANDLINE_APPEND because we
append KDUMP_COMMANDLINE_APPEND even cmdline is not taken from
/proc/cmdline.
append and remove is different, if one append a same param it does not matter
but if one add it to both append and remove, we do not know how to handle it.
the order is also a problem, should we remove then append? or append then remove..
Also, I'm afraid that no one will actually specify a parameter in both
KDUMP_COMMANDLINE and KDUMP_COMMANDLINE_REMOVE.
It is unlikely, but if there's some mistake we need do some error handling,
instead of doing the error handling we can just limit it to /proc/cmdline.
Thanks
Dave
Thanks,
Dangyi
_______________________________________________
kexec mailing list
kexec(a)lists.fedoraproject.org
https://lists.fedoraproject.org/mailman/listinfo/kexec