On Fri, Sep 26, 2014 at 09:34:55 -0400, Vivek Goyal wrote:
On Thu, Sep 25, 2014 at 12:15:49PM +0200, Martin Milata wrote:
system-config-kdump has hardcoded whitelist of major numbers for block devices that can be used as raw kdump targets. With the current list it does not show virtio disks [1] as possible targets. The major device number for virtio is assigned dynamically, thus I cannot simply add a new number.
This is interesting. I did not know that system-config-kdump does this kind of hardcoding.
Yes, it does all kinds of weird things:/
I have no idea how the major numbers in the list were chosen. I see these possibilities for fixing the bug:
I also have no idea. If there is a block device, it should be able to act as a raw device, isn't it? If yes, we should just check if a device is block device or not, IMO.
Secondly, we also should do some checks if raw device has a file system or if a raw device is a slave device of another block device and warn user about it.
I forgot to mention that s-c-kdump already does that - if the device is mounted or otherwise used (e.g. device mapper) then it is excluded from the list.
Thanks, Martin