On 09/09/2015:05:59:46 PM, Dave Young wrote:
Ccing Pratyush and Vivek, hope any of you can have time to review
Thanks for CCing.
On 09/08/15 at 10:22am, Zhou Wenjian wrote:
> +Parallel Dumping Operation
> +Kexec allows kdump using multiple cpus. So parallel feature can
> +accelerate dumping greatly, especially in doing compress and filter.
I think 'considerably' or 'substantially' would be a better fit than
Similarly, 'executing' or 'performing' than 'doing'.
> +For example:
> +"makedumpfile -c --num-threads [THREAD_NUM] /proc/vmcore dumpfile"
> +has 2 or more times performance of
> +- First, confirm that you are using a sufficiently new kernel version
> +- Then, you need to specify how many cpus you use in a capture
In stead of 'First' and 'Then', I think following would be better:
1) Make sure that you are using.....
2) You need to specify....
> +Note strongly that you should use necessary and sufficnet amount of
Note: You must use necessary and sufficient number of .....
> +cpus on a capture kernel. IOW, don't use too many cpus on a capture
> +kernel, or the capture kernel easily leads to panic due to Out Of
s/easily leads/may lead/
> +There are kernel data structures and drivers allocating memory in
> +proportion to the number of cpus. More you use cpus, more and
> +memory system consumes. Memory is rare, limited resource in a capture
> +kernel. Reserved memory should be kept as less as possible. When
> +configuring nr_cpus option, you should confirm that kdump certainly
> +successfully works without leading to panic due to Out Of Memory on a
> +capture kernel.
Above paragraph seems is not necessary.