On Mon, 2015-10-19 at 15:33 +0800, Dave Young wrote:
> I think removing KDUMP_COMMANDLINE_REMOVE regardless of where
cmdline
> comes from is more consistent with KDUMP_COMMANDLINE_APPEND because
we
> append KDUMP_COMMANDLINE_APPEND even cmdline is not taken from
> /proc/cmdline.
append and remove is different, if one append a same param it does
not matter
but if one add it to both append and remove, we do not know how to
handle it.
the order is also a problem, should we remove then append? or append
then remove..
I think it's better to remove first then append.
>
> Also, I'm afraid that no one will actually specify a parameter in
both
> KDUMP_COMMANDLINE and KDUMP_COMMANDLINE_REMOVE.
It is unlikely, but if there's some mistake we need do some error
handling,
instead of doing the error handling we can just limit it to
/proc/cmdline.
Sounds reasonable. Let me send the patch again.
And what about other existing items "crashkernel hugepages hugepagesz
panic_on_warn"? Should we make them all in KDUMP_COMMANDLINE_REMOVE?
Dangyi