On Thu, Nov 11, 2021 at 03:56:34PM +0800, Pingfan Liu wrote:
Hi Coiby,
Thanks for the quick response.
On Thu, Nov 11, 2021 at 3:01 PM Coiby Xu <coxu(a)redhat.com> wrote:
>
> HI Pingfan,
>
> I haven't use kdump_pre and kdump_post much. Could you explain the use
> cases of referring the storage or network device and also give some examples
> of not adhering to 'Supported dump target types and requirements' in
> kexec-kdump-howto.txt?
>
kdump_pre and kdump_post are used for customized scripts. The user can
have his private code to do some tests and log in kdump kernel.
Here is an unbreached example looks like:
"mount /dev/sda2 /mnt/disk"
While in the standard code, persistent device names are used, so it
will not suffer change from the produced kernel to kdump kernel.
This issue is raised by our QE. And hope my answer can resolve your concern.
Thanks for the explanation! So similarly, the user should use kdump-eth*
when the network interface name is eth* in the 1st kernel. This info
doesn't exist in the section 'Supported dump target types and requirements'
and at least for me it's difficult to apply what's described in the
section, so maybe it's better to provide a list of standard examples and
unbleached examples for the user. Btw, man doc use groff. Maybe we can put
this list into a variable thus there is no need to duplicate the list in
kdump.conf since the list applies to both kdump_pre and kdump_post.
Thanks,
Pingfan
> On Thu, Oct 21, 2021 at 10:21:40AM +0800, Pingfan Liu wrote:
> >Signed-off-by: Pingfan Liu <piliu(a)redhat.com>
> >---
> > kdump.conf.5 | 7 +++++--
> > kexec-kdump-howto.txt | 6 ++++++
> > 2 files changed, 11 insertions(+), 2 deletions(-)
> >
> >diff --git a/kdump.conf.5 b/kdump.conf.5
> >index 2c5a2bc..385ae3e 100644
> >--- a/kdump.conf.5
> >+++ b/kdump.conf.5
> >@@ -118,8 +118,11 @@ All files under /etc/kdump/post.d are collectively sorted
> > and executed in lexical order, before binary or script
> > specified kdump_post parameter is executed.
> > .PP
> >-Note that scripts written for use with this directive must use
> >-the /bin/bash interpreter.
> >+Note that scripts written for use with this directive must use the /bin/bash
> >+interpreter. And since these scripts run in kdump enviroment, the reference to
> >+the storage or network device in the scripts should adhere to the section
> >+'Supported dump target types and requirements' in
kexec-kdump-howto.txt.
>
> I think you should also change similar texts for kdump_pre.
>
> >+
> > .RE
> >
> > .B kdump_pre <binary | script>
> >diff --git a/kexec-kdump-howto.txt b/kexec-kdump-howto.txt
> >index 88af607..1aeffc7 100644
> >--- a/kexec-kdump-howto.txt
> >+++ b/kexec-kdump-howto.txt
> >@@ -621,6 +621,9 @@ If /etc/kdump/post.d directory exist, All files in the
directory are
> > collectively sorted and executed in lexical order, before binary or script
> > specified kdump_post parameter is executed.
> >
> >+In these scripts, the reference to the storage or network device should adhere
> >+to the section 'Supported dump target types and requirements'
> >+
> > Kdump Pre-Capture Executable
> > ----------------------------
> >
> >@@ -634,6 +637,9 @@ kdump_pre parameter is executed.
> > Even if the binary or script in /etc/kdump/pre.d directory returns non 0
> > exit status, the processing is continued.
> >
> >+In these scripts, the reference to the storage or network device should adhere
> >+to the section 'Supported dump target types and requirements'
>
> And similar texts should also be added for kdump_post.
>
> >+
> > Extra Binaries
> > --------------
> >
> >--
> >2.31.1
> >_______________________________________________
> >kexec mailing list -- kexec(a)lists.fedoraproject.org
> >To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> >Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> >List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
> >Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
>
> --
> Best regards,
> Coiby
>
--
Best regards,
Coiby