Re: [Patch v2 2/2] adding the parsed path to etc/kdump.conf of kdump initrd

[Baoquan He]

On 12/22/14 at 03:12pm, Dave Young wrote:
>  On 12/18/14 at 02:07pm, Baoquan He wrote: 
  
>  >          _path=${_save_path##"$_mntpoint"}
>  > -        sed -i -e "s#^path[[:space:]]\+$_save_path#path $_path#"
> /tmp/$$-kdump.conf
>  > +        if [ -n "$(get_option_value "path")" ]; then
>  > +            sed -i -e "s#^path[[:space:]]\+$_save_path#path $_path#"
> /tmp/$$-kdump.conf
>  > +        else
>  > +            echo "path $_path" >> /tmp/$$-kdump.conf
>  > +        fi
>  
>  Baoquan, seems above code is using $_path which is a path relative to mount point
>  in 2nd kernel $$-kdump.conf, so how about just dropping the sed line, use below instead:
>
>  1) delete original ^path line in /tmp/$$-kdump.conf
>  2) echo "path $_path" >> /tmp/$$-kdump.conf 
Yes, it's another way. Will try.

>  
>  It looks simple than original sed logic.
>  
>  Thanks
>  Dave
>  _______________________________________________
>  kexec mailing list
>  kexec(a)lists.fedoraproject.org
>  https://lists.fedoraproject.org/mailman/listinfo/kexec