On 01/02/15 at 08:45am, Vivek Goyal wrote:
On Thu, Dec 18, 2014 at 10:34:42AM +0800, WANG Chao wrote:
> I don't think it's a good idea to hard code removal of other kernel
> parameters which won't hurt 2nd kernel, like panic_on_warn or something
> like that. It's rare that one needs panic_on_warn on purpose in 2nd
> kernel. But we shouldn't make the assumption that no one needs it.
> I think it's better to do it in our kexec-tools as a distribution
> specific manner.
Agreed. Distribution specific scripts should be a better place for this
kind of change instead of modifying kexec-tools. kexec-tools should have
no business deciding whether panic_on_warn makes sense in second kernel
Yeah, most likely. But panic_on_warn is a little special then on this
issue. panic_on_warn is not the stuff which doesn't hurt 2nd kernel,
it surely does. I can't imagine any motivation someone expect a
panic_on_warn action in kdump kernel.
That means removing panic_on_warn whould be a common requirement, no
matter what distribution. On this point it's suitable to remove it in
kexec mailing list