Hi Coiby,
On Wed, 3 Aug 2022 21:23:21 +0800 Coiby Xu coxu@redhat.com wrote:
Hi Philipp,
On Fri, Jul 29, 2022 at 05:35:14PM +0200, Philipp Rudo wrote:
Hi Coiby,
except for the questions on the first patch the series looks fine by me.
Reviewed-by: Philipp Rudo prudo@redhat.com
Thanks for reviewing the patch set! It has been merged with the issues of the first patch resolved.
ok... should have read all messages in the thread first...
Anyway, it's only a small nit. When you like you can ignore the comment I made for the first patch.
Thanks Philipp
On Fri, 13 May 2022 14:08:07 +0800 Coiby Xu coxu@redhat.com wrote:
This patch set enables the integration tests (i.e. the test cases in tests/) for Fedora 35, 36 and 37 cloud base images.
v3:
- use "unmount -R" to umount both the root and boot partition [Kairui]
- add a code comment for the change of root node [Kairui]
- fix the error of using the first partition as boot partition (the 2nd partition is the boot parition) for Fedora >= 35
- specify backing format for "qemu-img create" as required by newer qemu-img
- specify the Fedora version for fedpkg sources
v2:
- check LAST_PARTITION/root/root instead of LAST_PARTITION/root [Kairui]
- improve commit message
Coiby Xu (3): tests: correctly mount the root and also the boot partitions for Fedora 35, 36 and rawhide Cloud Base Image tests: specify the backing format for the backing file when using qemu-img create tests: specify the Fedora version when running fedpkg sources
tests/Makefile | 2 +- tests/scripts/image-init-lib.sh | 31 +++++++++++++++++++++++++++---- 2 files changed, 28 insertions(+), 5 deletions(-)