On 02/24/14 at 10:54am, Vivek Goyal wrote:
On Mon, Feb 24, 2014 at 04:37:15PM +0800, Baoquan He wrote:
On 02/20/14 at 12:01pm, Vivek Goyal wrote:
On Thu, Feb 20, 2014 at 02:00:54PM +0800, Baoquan He wrote:
- We should do this checking *only* if user has not specified any disk and path in /etc/kdump.conf. If user has specified root disk in /etc/kdump.conf, then we should continue to dump.
Here user has not specificed any disk, but specified a path like "/home/user/test", and there's another disk mounted on this path, doesn't this need to be cared?
I think this should fail and give out en error message.
What if user decides do dump to root partition (even if there is another disk mounted on /var). I think we should have mechanism to address that.
I see that "path" is uncommented in kdump.conf. So kdump code has to assume that user specified it.
But disk is not uncommented and we take rootfs as default.
So we can do following.
If dump target is specified in kdump.conf, then just dump to it. User wants it that way.
If dump target is not mentioned in kdump.conf and are dumping to rootfs by default, in that case we need to check whether there are other disks mounted in "path" and fail service.
The example you gave, yes, there kdump service will fail as user has not specified the disk and there is another disk mounted on /home/user/test path.
Yeah, can't agree more. Thanks for making this clear.
Thanks Vivek _______________________________________________ kexec mailing list kexec@lists.fedoraproject.org https://lists.fedoraproject.org/mailman/listinfo/kexec