Re: [PATCH] fadump: avoid status check while starting in fadump mode

[Philipp Rudo]

Hi Hari,

just one question.

On Mon, 21 Nov 2022 18:56:08 +0530
Hari Bathini  wrote:
> With kernel commit 607451ce0aa9b ("powerpc/fadump: register for fadump
> as early as possible"), 'kdumpctl start' prematurely returns with the

This patch also disables the check for kernels without the commit
mentioned. Is that intended? If that's the case

Reviewed-by: Philipp Rudo
> below message:
> "Kdump already running: [WARNING]"
>
> instead of setting default initrd with dump capture capability as
> required for fadump. Skip status check in fadump mode to avoid this
> problem.
> Signed-off-by: Hari Bathini
>
> kdumpctl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kdumpctl b/kdumpctl
> index 03c91f3..d6fb7bd 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -1059,7 +1059,7 @@ start()
>    	return 1
>    fi
> if check_current_status; then
> if [[ $DEFAULT_DUMP_MODE == "kdump" ]] && check_current_kdump_status; then
> dwarn "Kdump already running: [WARNING]"
> return 0
> fi