On 12/04/14 at 03:42pm, Vivek Goyal wrote:
On Wed, Nov 26, 2014 at 06:46:22PM +0800, WANG Chao wrote:
Move kdump_setup_netdev in iscsi handling path early. Because when we detect ibft or firmware iscsi session, we will bail out early, but still need to bring up network device in 2nd kernel.
Chao, it says V2. Is it V2 of hardware iscsi support patches?
Yeah. V1 is the patchset with three patches. v1 used kernel command and you didn't like that idea. So I totaly discard that method in v2.
It is worth mentining in changelog that who will take care of rest when ibft or firmware iscsi is in force. In fact what is firmware iscsi?
Actually it's a term I made up. "Firmware iscsi" stands for hardware iscsi and ibft. They both have the same attribute "node.discovery_type=fw", so I figured maybe I can call it "firmware iscsi"
Thanks Vivek
Signed-off-by: WANG Chao chaowang@redhat.com
dracut-module-setup.sh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh index dcebc47..b6218b3 100755 --- a/dracut-module-setup.sh +++ b/dracut-module-setup.sh @@ -434,8 +434,15 @@ kdump_setup_iscsi_device() { return 1 fi
- tgt_name=$(kdump_iscsi_get_rec_val ${path} "node.name") tgt_ipaddr=$(kdump_iscsi_get_rec_val ${path} "node.conn[0].address")
netdev=$(/sbin/ip route get to ${tgt_ipaddr} | \
sed 's|.*dev \(.*\).*|\1|g')
srcaddr=$(echo $netdev | awk '{ print $3; exit }')
netdev=$(echo $netdev | awk '{ print $1; exit }')
kdump_setup_netdev $netdev $srcaddr $tgt_ipaddr
tgt_name=$(kdump_iscsi_get_rec_val ${path} "node.name")
# get and set username and password details username=$(kdump_iscsi_get_rec_val ${path} "node.session.auth.username")
@@ -452,13 +459,6 @@ kdump_setup_iscsi_device() {
[ -n "$username_in" ] && userpwd_in_str=":$username_in:$password_in"
- netdev=$(/sbin/ip route get to ${tgt_ipaddr} | \
sed 's|.*dev \(.*\).*|\1|g')
- srcaddr=$(echo $netdev | awk '{ print $3; exit }')
- netdev=$(echo $netdev | awk '{ print $1; exit }')
- kdump_setup_netdev $netdev $srcaddr $tgt_ipaddr
- # prepare netroot= command line # FIXME: IPV6 addresses require explicit [] around $tgt_ipaddr # FIXME: Do we need to parse and set other parameters like protocol, port
-- 1.9.3
kexec mailing list kexec@lists.fedoraproject.org https://lists.fedoraproject.org/mailman/listinfo/kexec