Re: [PATCH 0/4] remove "root=X" for kdump boot
Looks good from fadump perspective..
Thanks
Hari
On Thursday 30 March 2017 02:46 PM, Dave Young wrote:
For fadump part, it seems good, but let's cc Hari to confirm
about it.
----- Original Message -----
From: "Xunlei Pang" <xlpang(a)redhat.com>
To: kexec(a)lists.fedoraproject.org
Cc: "Xunlei Pang" <xlpang(a)redhat.com>
Sent: Thursday, March 30, 2017 4:10:18 PM
Subject: [PATCH 0/4] remove "root=X" for kdump boot
Previously, I've sent out two versions of the targets hook framework.
after discussion we decided to finish "removing root=X" first using
the approach of v1, thus I drafted this patch series. We can continue
the targets hook framework if we really need it in the future.
This patch series focuses on removing "root=X" for kdump, and always
add the dump target(even for root target) via dracut's "--mount ..."
explicitly.
There are two cases we don't remove "root=X":
1) "default dump_to_rootfs" is specified.
2) fadump, AFAIK fadump can directly switch to root after vmcore dumping,
I am not sure, would be apprieciated if someone has a clear answer.
PATCH1 is a bug fix I found during my nfs diskless tests.
PATCH2 is a bug fix needed by PATCH3.
PATCH3 is the actual implemenation.
PATCH4 is a revert patch due to having PATCH3.
Xunlei Pang (4):
module-setup: install network for diskless environment
kdumpctl: fix a bug in remove_cmdline_param()
kdumpctl: remove "root=X" for kdump boot
Revert "kdumpctl: filter 'root' kernel parameter when running in live
images"
dracut-module-setup.sh | 8 +++++---
kdumpctl | 42 +++++++++++++++++++++++++++++++-----------
live-image-kdump-howto.txt | 2 ++
mkdumprd | 29 +++++++++--------------------
4 files changed, 47 insertions(+), 34 deletions(-)