On 01/22/15 at 04:51pm, Minfei Huang wrote:
On 01/22/15 at 03:39pm, Dave Young wrote:
> Hi, Minfei
>
> Overall structure looks good to me except two nickpicks.
>
> On 01/15/15 at 07:28pm, Minfei Huang wrote:
> > Currently kdump doesn't support ipv6 nfs/ssh dump. Ipv6 is the latest
version
> > of the Internet Protocal. So it is a significant feture for kdump to enhance
> > to support ipv6.
> >
> > What is the main difference in userspace between ipv4 and ipv6 is the ip
> > address format.
> > For ipv6 nfs dump:
> > if ipv6 address type is link scope, /etc/kdump.conf should be edited like
> > "nfs [fe80::5054:ff:fe48:ca80%eth0]:/mnt"
> > else /etc/kdump.conf should be edited like "nfs
[2001:db8:0:f101::2]:/mnt"
> > For ipv6 ssh dump
> > if ipv6 address type is link scope, /etc/kdump.conf should be edited like
> > "ssh root at fe80::5054:ff:fe48:ca80%eth0"
> > else /etc/kdump.conf should be edited like "ssh root at
2001:db8:0:f101::2"
> >
> > How to create a ipv6 enviromnet.
> > 1): Reserving two beaker machine with family fedora.
> > 2): Choosing a beaker machine as a nfs/ssh server and delete it's ipv4
address
> > by "ip address del ipv4-address dev nicname"
> > 3): Configuring the /etc/kdump.conf like mentioned above.
> >
> > Signed-off-by: Minfei Huang <mhuang(a)redhat.com>
> > ---
> > dracut-kdump.sh | 4 +-
> > dracut-module-setup.sh | 143
++++++++++++++++++++++++++++++++++---------------
> > 2 files changed, 103 insertions(+), 44 deletions(-)
> >
> > diff --git a/dracut-kdump.sh b/dracut-kdump.sh
> > index e062665..7e6b810 100755
> > --- a/dracut-kdump.sh
> > +++ b/dracut-kdump.sh
> > @@ -121,9 +121,9 @@ get_host_ip()
> > then
> > kdumpnic=$(getarg kdumpnic=)
> > [ -z "$kdumpnic" ] && echo "kdump: failed to
get kdumpnic!" && return 1
> > - _host=`ip addr show dev $kdumpnic|grep 'inet '`
> > + _host=`ip addr show dev $kdumpnic|grep 'inet'`
>
> Per previous discussion it should work for most cases with minimal modifications
> we can address the issue if we have a bug report.
>
> As for the code itself, a nitpick:
> In case ipv4 & ipv6, there are multiple line, should filter with |head -n 1 ?
>
Hi, Dave!
It works when the ipv4 & ipv6 is up. We will use the command
"cut -d' ' -f2" to get the ip address who we need.
The HOST_IP is correct, though the variable _host contains ipv4 & ipv6
config.
The variable will get the value from first line, but code itself looks odd..
Thanks
Dave