Hello Kairui,
Thanks a lot for your reply.
On Mon, Jan 20, 2020 at 10:38 AM Kairui Song <kasong(a)redhat.com> wrote:
On Sat, Jan 18, 2020 at 9:34 PM Kairui Song <kasong(a)redhat.com> wrote:
>
> On Fri, Jan 17, 2020 at 4:44 AM Bhupesh Sharma <bhsharma(a)redhat.com> wrote:
> >
> > Currently while trying to save vmcore via vlan eth interface, the Kdump
> > kernel fails with network unreachable message.
> >
> > This is because mkdumprd produces a vlan config that does not get
> > ip address for vlan on eth device.
> >
> > Fix the same via this patch.
> >
> > Signed-off-by: Bhupesh Sharma <bhsharma(a)redhat.com>
> > ---
> > dracut-module-setup.sh | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> > index e6358a8ab910..3edbe146d09e 100755
> > --- a/dracut-module-setup.sh
> > +++ b/dracut-module-setup.sh
> > @@ -307,10 +307,10 @@ kdump_setup_vlan() {
> > exit 1
> > elif kdump_is_bond "$_phydev"; then
> > kdump_setup_bond "$_phydev"
> > - echo " vlan=$_netdev:$_phydev" >
${initdir}/etc/cmdline.d/43vlan.conf
> > + echo " vlan=$(kdump_setup_ifname $_netdev):$_phydev" >
${initdir}/etc/cmdline.d/43vlan.conf
> > else
> > _kdumpdev="$(kdump_setup_ifname $_phydev)"
> > - echo " vlan=$_netdev:$_kdumpdev ifname=$_kdumpdev:$_netmac"
> ${initdir}/etc/cmdline.d/43vlan.conf
> > + echo " vlan=$(kdump_setup_ifname $_netdev):$_kdumpdev
ifname=$_kdumpdev:$_netmac" > ${initdir}/etc/cmdline.d/43vlan.conf
> > fi
> > }
> >
> > --
> > 2.7.4
> >
>
> Looks good to me, thanks for the fix.
>
> Acked-by: Kairui Song <kasong(a)redhat.com>
>
> --
> Best Regards,
> Kairui Song
Hi Bhupesh,
I found on my machine currently vlan dump only with network-legacy
dracut module enabled.
(Add dracut_args --add "network-legacy" to /etc/kdump.conf)
And I tested you patch using legacy module, it worked well.
Else vlan is still failing. The patch should be good, maybe a dracut but.
How did it work on your side? Did you test on latest Fedora release
and observed similar situation?
I am sorry I was not able to test it on Fedora. I did some checks on
RHEL machines.
But I think the same fix is valid in case of Fedora as well.
I will try to setup a Fedora environment to test the same as well.
Thanks,
Bhupesh