On Thu, Nov 13, 2014 at 03:56:34PM +0800, WANG Chao wrote:
This patchset adds support for hardware iscsi. It's previously
one big patch,
and now I break it down to three.
Last time I mentioned that first we need to move some pieces which are
in kdump to iscsi module of dracut. You were of the opinion that there
are no such pieces.
I am looking at the code now and I am wondering that why following should
not go in 95iscsi/ module.
This function seems to go through all the block devices. I think it
should be dracut's job to call in to iscsi module with each block
device and see if any of these is iscsi backed block device and
let iscsi module pull in relevant dependencies.
For example, look at check() function of 95iscsi/module-setup.sh and
it does check if the passed in device is iscsi device or not.
module-setup.sh also seems to be pulling in right modules. What I
am not sure is that where is it preparing right configuation info
which is passed on command line to dracut. rd.iscsi= etc.
Kdump module should ideally be concerned with only setting up
kdump related configuration and not anything else. That's how
dracut is structured. Now if kdump module also starts configuring
iscsi configurations, then it is violation of that structure.
Along with this patch, I add the infrastructure of determine iBFT,
but it's not
complete yet, because I don't know how to determine it in a reliable way. Mark
this part as FIXME. Perhaps in the future someone ask for iBFT and we can
gather some data there, and finish this part.
WANG Chao (3):
module-setup: add two functions to determine hardware iscsi
module-setup: add two functions to determine iBFT
Hardware iSCSI support
dracut-module-setup.sh | 81 +++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 80 insertions(+), 1 deletion(-)
kexec mailing list