On Fri, Mar 28, 2014 at 11:08:26AM +0800, Baoquan He wrote:
[..]
I didn't find the returned value will be /proc if null target is passed to get_mntpoint_from_target(). Thanks for pointing this out.
However, though patch3 doesn't use this function, from the implementation of function point of view, can we just keep the implementation to prepare the possibility that one day someone will need make a path with a null target?
Then I want to change it like below, it can be used by pair of target and save_path, also can be used with only save_path. The code matches the name of function. How do you think about it?
make_absolute_save_path() { local _target=$1 local _mnt
[ -n $_target ] && _mnt=$(get_mntpoint_from_target $1) echo "${_mnt}/$SAVE_PATH"}
ok, I am fine with this too.
Vivek