On 07/24/14 at 09:43am, Vivek Goyal wrote:
On Tue, Jul 22, 2014 at 03:20:06PM +0800, WANG Chao wrote:
[..]
do_default_action() {
- wait_for_loginit
- echo "Kdump: Error Occured, doing default action"
Ho about following.
"Kdump: Executing default action $DEFAULT_ACTION"
This looks good to me.
I think error occurred is implied. And we should output an error message where actual error happened.
That's hard to implement. Because we don't propagate the error upwards when certain systemd unit fails.
But I wouldn't worry much about it. Because there would be messages for any failure on the console. And it's the same for our kdump.sh.
I had recommened similar message in RHEL6, I guess. Can you please look it up and try to keep message same.
It's hard to be exactly the same with RHEL6. Since RHEL6 uses the following output:
"XXX failed. Executing default action"
I think "Kdump: Executing default action $DEFAULT_ACTION" is good enough.
What do you think?
Thanks WANG Chao
Let us try our best to keep the messages consistent across all releases.
Thanks Vivek