On 12/13/19 at 05:46pm, Kairui Song wrote:
On Tue, Dec 3, 2019 at 1:30 PM Kairui Song <kasong(a)redhat.com>
wrote:
>
> Previous commit f13eab6 ('mkdumprd: simplify dracut args parsing')
> break dracut arguments parsing for some use case, this should fix it
> well.
>
> Passed nfs/local/iscsi/ssh dump test, and with extra dracut_argss.
>
> Signed-off-by: Kairui Song <kasong(a)redhat.com>
> ---
> mkdumprd | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mkdumprd b/mkdumprd
> index 76ae7a0..6c33fc5 100644
> --- a/mkdumprd
> +++ b/mkdumprd
> @@ -41,15 +41,15 @@ add_dracut_arg() {
> }
>
> add_dracut_module() {
> - add_dracut_arg "--add" "$1"
> + add_dracut_arg "--add" "\"$1\""
> }
>
> add_dracut_mount() {
> - add_dracut_arg "--mount" "$1"
> + add_dracut_arg "--mount" "\"$1\""
> }
>
> add_dracut_sshkey() {
> - add_dracut_arg "--sshkey" "$1"
> + add_dracut_arg "--sshkey" "\"$1\""
> }
>
> # caller should ensure $1 is valid and mounted in 1st kernel
> --
> 2.23.0
>
Hi, any comment on this? This fixes my previous commit which
introduced some breakage, this one is better tested and should be
good.
Kairui, looks good:
Acked-by: Dave Young <dyoung(a)redhat.com>
Thanks
Dave