Re: [PATCH] earlykdump: provide a prompt message during the rebuild of kdump initramfs.

[Kairui Song]

On Fri, May 10, 2019 at 4:37 PM Lianbo Jiang <lijiang(a)redhat.com&gt; wrote:
>  Early kdump inherits the settings of normal kdump, so any changes that
>  caused normal kdump rebuilding also require rebuilding the system initramfs
>  to make sure that the changes take effect for early kdump.
>
>  Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com&gt;
>  ---
>   kdumpctl | 2 ++
>   1 file changed, 2 insertions(+)
>
>  diff --git a/kdumpctl b/kdumpctl
>  index 75eebacef92b..7c2f53cabe59 100755
>  --- a/kdumpctl
>  +++ b/kdumpctl
>  @@ -628,6 +628,7 @@ check_rebuild()
>          fi
>
>          echo "Rebuilding $TARGET_INITRD"
>  +       echo "Tips: If early kdump is enabled, also require rebuilding the system
> initramfs to ensure that the changes take effect for early kdump."
>          rebuild_initrd
>          return $?
>   }
>  @@ -1140,6 +1141,7 @@ rebuild() {
>          fi
>
>          echo "Rebuilding $TARGET_INITRD"
>  +       echo "Tips: If early kdump is enabled, also require rebuilding the system
> initramfs to ensure that the changes take effect for early kdump."
>          rebuild_initrd
>          return $?
>   }
>  --
>  2.17.1
>  
Hi Lianbo,

Will it be a bit noise if we print this message every time it rebuilds
even if user don't use early kdump? Is there a way to know if user is
using early kdump?

-- 
Best Regards,
Kairui Song