On 07-Jul-2016 9:07 pm, "Don Zickus" <dzickus@redhat.com> wrote:
>
> On Thu, Jul 07, 2016 at 08:24:00AM +0800, Dave Young wrote:
> > On 07/06/16 at 10:26am, Don Zickus wrote:
> > > On Wed, Jul 06, 2016 at 09:28:15AM +0800, Dave Young wrote:
> > > > Ccing Don see if he has any comments about these wdt enablement patches.
> > >
> > > Unfortunately, I am not on this mailing list.  Pointer to the archive?
> >
> > Don, it is not sorted correctly in a thread, I'm not sure how to get the
> > right threaded link for the archive, anyway will cc you the several patches:
> > https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/
> >
> > If you would like to subscribe, here is a link, but seems Fedora mail list
> > need login with an Fedora account first to subscribe now:
> > https://lists.fedoraproject.org/admin/lists/kexec.lists.fedoraproject.org/
>
> Thanks for the patches.  I don't see any issues.  Everything makes sense.
> The first patch is the bulk of the work.  I haven't convinced myself all the
> cases are covered, but you can find/fix the corner cases later.  For
> example, I was wondering what happens if a wd module is already accidentally
> added to dracut, then it doesn't get rebuilt (but maybe it doesn't
> matter??).

Yes it won't matter, if dracut has accidentally added it and watchdog is active, there will not be any rebuilt.  But if it is inactive, then there will a rebuild and accidentally added driver will be removed.

>
> I will assume that a new kexec-tools update will force a rebuild to properly
> pick up the new dracut -a/o watchdog option (this gets rid of the silly
> initial conversion corner cases)?
>
>
> Nice work!  Good to finally see this. :-)

Thanks a lot Don!!!

>
> Cheers,
> Don
>
> >
> > Thanks
> > Dave
> > >
> > > Cheers,
> > > Don
> > >
> > > >
> > > > On 07/05/16 at 11:41am, Pratyush Anand wrote:
> > > > > Fedora dracut-044-75 release has all the component needed to support initrd
> > > > > rebuild in case of watchdog state change. Therefore sending these patches
> > > > > for inclusion in kexec-tools.
> > > > >
> > > > > Please note that these patches should only be added in those fedora
> > > > > versions which has dracut version dracut-044-75 or latter. Anyway, we
> > > > > already have dependency specified in spec file as well.
> > > > >
> > > > > Pratyush Anand (5):
> > > > >   kdumpctl: force rebuild in case of watchdog state change
> > > > >   watchdog: Add nowdt argument in kdump.conf
> > > > >   watchdog: do not add watchdog module in rd.driver.pre now
> > > > >   Watchdog: Add notes for kdumpctl man page
> > > > >   spec: Update to add dependency on dracut version >= 044-75
> > > > >
> > > > >  dracut-module-setup.sh |  9 ---------
> > > > >  kdump.conf             |  4 ++++
> > > > >  kdump.conf.5           |  5 +++++
> > > > >  kdumpctl               | 34 +++++++++++++++++++++++++++++++++-
> > > > >  kdumpctl.8             |  9 +++++++++
> > > > >  kexec-tools.spec       |  3 ++-
> > > > >  mkdumprd               |  8 +++++++-
> > > > >  7 files changed, 60 insertions(+), 12 deletions(-)
> > > > >
> > > > > --
> > > > > 2.5.5
> > > > > _______________________________________________
> > > > > kexec mailing list
> > > > > kexec@lists.fedoraproject.org
> > > > > https://lists.fedoraproject.org/admin/lists/kexec@lists.fedoraproject.org