Hi Coiby,
finally I get some time to go through my mail backlog...
On Mon, 22 Aug 2022 20:31:32 +0800
Coiby Xu <coxu(a)redhat.com> wrote:
Hi Philipp,
Thanks for carefully reviewing the patch!
On Mon, Aug 01, 2022 at 04:59:30PM +0200, Philipp Rudo wrote:
>Hi Coiby,
>
>On Tue, 21 Jun 2022 14:57:16 +0800
>Coiby Xu <coxu(a)redhat.com> wrote:
>
>> NetworkManager defaults to use keyfile i.e. .nmconnnection file but
>> still supports reading ifcfg-* file [1]. Make use of
>> "nmcli connection clone --temporary" to automatically convert a
ifcfg-*
>> file to a .nmconnection file.
>>
>> [1]
https://fedoraproject.org/wiki/Changes/NetworkManager_keyfile_instead_of_...
>>
>> Signed-off-by: Coiby Xu <coxu(a)redhat.com>
>> ---
>> dracut-module-setup.sh | 53 ++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 53 insertions(+)
>>
>> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
>> index 3dc597f..dba023d 100755
>> --- a/dracut-module-setup.sh
>> +++ b/dracut-module-setup.sh
>> @@ -1,10 +1,20 @@
>> #!/bin/bash
>>
>> +_DRACUT_KDUMP_NM_TMP_DIR="/tmp/$$-DRACUT_KDUMP_NM"
>
>Why don't you use mktemp -d?
I just tried mktemp but found two issues,
- mktemp and cleanup somehow would be called 4 times (it seems dracut
source dracut-module-setup.sh many times)
- after running a network test, some of the temp folders are not
deleted
Alright. In that case your approach is better.
Thanks
Philipp