On Mon, 2015-10-19 at 14:52 +0800, Dave Young wrote:
How about remove them only for /proc/cmdline like below:
and fix the comment in sysconfig to mentione it is only for removing
from /proc/cmdline.
if [ -z "$KDUMP_COMMANDLINE" ]; then
cmdline=`cat /proc/cmdline`
remove_cmdline_param ${KDUMP_COMMANDLINE_REMOVE}
else
cmdline=${KDUMP_COMMANDLINE}
fi
I think removing KDUMP_COMMANDLINE_REMOVE regardless of where cmdline
comes from is more consistent with KDUMP_COMMANDLINE_APPEND because we
append KDUMP_COMMANDLINE_APPEND even cmdline is not taken from
/proc/cmdline.
Also, I'm afraid that no one will actually specify a parameter in both
KDUMP_COMMANDLINE and KDUMP_COMMANDLINE_REMOVE.
Thanks,
Dangyi