Hi Kenneth,
Can you provide more info like what argument do you have in your fstab entry?
What's the mount status before and after the remount? What's you kdump config?
kdump is already dropping arguments like "ro", "nofail" which are
causing problems,
and remount as rw shouldn't cause such problem.
On Mon, Oct 8, 2018 at 1:46 PM Kenneth Dsouza <kdsouza(a)redhat.com> wrote:
From: Kenneth D'souza <kdsouza(a)redhat.com>
Currently the script does not check if the dump target is read-only and would
always mount to read-write mode. This caused an issue with nfs mount as
the fstab options would be reconsidered while remounting to read-write mode.
The remount would fail with the below error as all options cannot be changed
runtime.
mount.nfs: an incorrect mount option was specified
Which in result would not save the vmcore on the dump target.
This patch addresses this issue by checking the dump target status for read-only.
If yes, remount to read-write mode without reconsidering the fstab options.
Signed-off-by: Kenneth D'souza <kdsouza(a)redhat.com>
---
kdump-lib-initramfs.sh | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh
index 2c18c87..8adcba2 100755
--- a/kdump-lib-initramfs.sh
+++ b/kdump-lib-initramfs.sh
@@ -100,7 +100,13 @@ dump_fs()
echo "kdump: saving to $_mp/$KDUMP_PATH/$HOST_IP-$DATEDIR/"
- mount -o remount,rw $_mp || return 1
+ # Only remount to read-write mode if the dump target is mounted read-only.
+ check_status=$(grep "\srw[\s,]" /proc/mounts | grep -i $_mp)
+ if [ -z "$check_status" ]; then
+ echo "kdump: Mounting Dump target $_dev in rw mode."
+ mount -o remount,rw $_dev $_mp || return 1
+ fi
+
mkdir -p $_mp/$KDUMP_PATH/$HOST_IP-$DATEDIR || return 1
save_vmcore_dmesg_fs ${DMESG_COLLECTOR}
"$_mp/$KDUMP_PATH/$HOST_IP-$DATEDIR/"
--
2.14.3
_______________________________________________
kexec mailing list -- kexec(a)lists.fedoraproject.org
To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
--
Best Regards,
Kairui Song