On Thu, Aug 6, 2020 at 7:27 PM Dave Young <dyoung(a)redhat.com> wrote:
Hi Kairui,
I thought to do some test about this series, but I have not got time on
it. I see below erros (probably I applied your v1):
[root@dhcp-128-65 dyoung]# kdumpctl restart
kexec: unloaded kdump kernel
Stopping kdump: [OK]
Failed to detect default initrd location
Starting kdump: [FAILED]
That could because I always use a self-built kernel without any initrd.
Yes, that's the reason, this patch assumes there is a "default
initrd", and puts the kdump initramfs next to the "default initrd". I
can change the log to let it fail back to put the kdump initramfs next
to the kernel image.
On 07/31/20 at 05:32pm, Kairui Song wrote:
> This patch series refactor kernel image and initrd detection, fix kdump
> service failure on some Fedora machines which use
> /boot/<machine-id>/<kver>/vmlinuz as kernel installation destination.
>
> Also cover the atomic corner case properly by refering BOOT_IMAGE=
> cmdline param for kernel image location.
>
> Also introduce a kernel install hook to clean up the initramfs properly
> on kernel uninstall.
>
> Update from V1:
> - Add the kdump initramfs clean up hook to make sure it work with
> different kernel installation style.
>
> Kairui Song (4):
> Add a kernel install hook to clean up kdump initramfs
> early-kdump: Use consistent symbol link for kernel and initramfs
> Refactor kernel image and initrd detection code
> kdump-lib.sh: Remove is_atomic
>
> 60-kdump.install | 30 ++++++++++++
> dracut-early-kdump-module-setup.sh | 21 +++-----
> dracut-early-kdump.sh | 6 +--
> kdump-lib.sh | 78 +++++++++++++++++++++++-------
> kdumpctl | 44 ++++++++---------
> kexec-tools.spec | 3 ++
> 6 files changed, 123 insertions(+), 59 deletions(-)
> create mode 100755 60-kdump.install
>
> --
> 2.26.2
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
Thanks
Dave
--
Best Regards,
Kairui Song