Re: [f25 PATCH 0/4] patchset to correct the usage of "grep -q"

[Pingfan Liu]

----- Original Message -----
> From: "Dave Young" 
> To: "Pingfan Liu" 
> Cc: [e-mail], "Xunlei Pang" , "Baoquan He" 
> Sent: Wednesday, February 8, 2017 11:31:13 AM
> Subject: Re: [f25 PATCH 0/4] patchset to correct the usage of "grep -q"
>
> On 02/07/17 at 02:29pm, Pingfan Liu wrote:
> > The same issue, but arrange the fix in each separated file
> >
> > Pingfan Liu (4):
> >   kdump-lib.sh: fix incorrect usage with pipe as input for grep -q
> >   dracut-module-setup.sh: fix incorrect usage with  pipe as input for
> >     grep -q
> >   kdumpctl: fix incorrect usage with pipe as input for grep -q
> >   dracut-kdump.sh: fix incorrect usage with pipe as input for grep -q
> >
> > dracut-kdump.sh        |  2 +-
> >  dracut-module-setup.sh |  4 ++--
> >  kdump-lib.sh           | 12 ++++++------
> >  kdumpctl               |  2 +-
> >  4 files changed, 10 insertions(+), 10 deletions(-)
> >
> > --
> > 2.7.4
> > _______________________________________________
> > kexec mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> Hi Pingfan
>
> I suppose it is for Fedora rawhide (master branch) instead of F25?
> We post patches to master (rawhide) first, then if people request the
> bug as critical we can evaluate and backport to released versions.
>
> So can you repost with dropping f25 prefix?

OK
> Also about the `grep -q` can you give out a concrect example of the
> failure in some sample shell script?

set -o pipefail
cat test.file | grep -q "keyword"
echo $?

If test.file is big enough, it always returns 141. In my test, 7KB is enough, but I think the detail depends on the implement of pipe in kernel.
Should I append this into commit log?

Thx,
Pingfan