Re: [PATCH V4 0/4] kdumpctl: force rebuild when dump target is modified

[Dave Young]

On 04/21/16 at 09:18am, Dave Young wrote:
>  Hi, Pratyush
>  
>  On 04/20/16 at 03:37pm, Pratyush Anand wrote:
>  > When dump target is re-formatted then its UUID changes. These patches add
>  > support to recognize such changes and then force initramfs rebuild, if
>  > dracut argument has an UUID based root location.
>  > 
>  > Changes since v3:
>  > - "$ret" unquoted
>  > - No message for "$system_modified" != "0"
>  > - image_time is now global
>  > - is_dump_target_modified has been renamed as is_fs_uuid_changed
>  > 
>  
>  Another nitpick in patch 4/4:
>  +        is_fs_uuid_changed
>  +        ret=$?
>  +        if [ $ret -ne 0 ]; then
>  +                return $ret
>  +        fi
>  +
>  
>  Since only checking -ne 0 so no need to use $ret, directly use $? is ok. 
Oops, $ret is needed because you return the value, so please ignore above comment..

> 
> If no other comments I can merge it one week later with a manually modification.
> 
> For the whole series:
> 
> Reviewed-by: Dave Young <dyoung(a)redhat.com&gt;
> 
> Thanks
> Dave
> _______________________________________________
> kexec mailing list
> kexec(a)lists.fedoraproject.org
> http://lists.fedoraproject.org/admin/lists/[e-mail]