Having this said, with the nit in the first patch fixed the series
looks
good to me.
Reviewed-by: Philipp Rudo <prudo(a)redhat.com>
Thanks
Philipp
>
> >2) Monitor the thin pool and autoextend its size when it reached the threshold
> > during kdump.
> >
> >According to my testing, the memory consumption procedure for lvm2 thinp is the
thin pool
> >size-autoextend phase. For fedora and rhel9, the default crashkernel value is
enough. But
> >for rhel8, the default crashkernel value 1G-4G:160M is not enough, so it should
> >be handled particularly.
> >
> >v1 -> v2:
> >
> >1) Modified the usage of lvs cmd when check if target is lvm2 thinp
> > device.
> >2) Removed the sync flag way of mounting for lvm2 thinp target
> > during kdump, use "sync -f vmcore" to force sync data, and handle
> > the error if fails.
> >
> >v2 -> v3:
> >
> >1) Removed "sync -f vmcore" patch out of the patch set, for it is
> >addressing an issue which is not specifically to lvm2 thinp support for
> >kdump.
> >
> >v3 -> v4:
> >
> >1) Removed lvm2-monitor.service, implemented the monitor service with
> > a loop function within a shell script instead.
> >2) Add lvm2 thinp support for dump_raw, for it is addressing the similar
> > issue as dump_fs.
> >3) Dave suggested me to implement the lvm2 thin support in dracut
> > modules instead of kexec-tools. If you are OK with the
loop-function-shell-script
> > technical way, I will give a try to migrate it to dracut.
> >
> >v4 -> v5:
> >
> >1) A new 80lvmthinpool-monitor module [1] has been integrated in dracut.
> > Now we simply depend on it.
> >2) Add lvm2 thin provision selftest.
> >
> >[1]:
https://github.com/dracutdevs/dracut/pull/1842
> >
> >v5 -> v6:
> >
> >1) Code refactoring based on Philipp's comments.
> >2) Print warning if lvmthinpool-monitor module is not exist.
> >
> >Tao Liu (5):
> > Add lvm2 thin provision dump target checker
> > lvm.conf should be check modified if lvm2 thinp enabled
> > Add dependency of dracut lvmthinpool-monitor module
> > selftest: Only iterate the .sh files for test execution
> > selftest: Add lvm2 thin provision for kdump test
> >
> > dracut-module-setup.sh | 8 +++
> > kdump-lib-initramfs.sh | 10 ++++
> > kdump-lib.sh | 6 ++
> > kdumpctl | 1 +
> > tests/scripts/run-test.sh | 3 +-
> > .../lvm2-thinp-kdump/0-local-lvm2-thinp.sh | 59 +++++++++++++++++++
> > .../testcases/lvm2-thinp-kdump/lvm.conf | 5 ++
> > 7 files changed, 90 insertions(+), 2 deletions(-)
> > create mode 100755
tests/scripts/testcases/lvm2-thinp-kdump/0-local-lvm2-thinp.sh
> > create mode 100644 tests/scripts/testcases/lvm2-thinp-kdump/lvm.conf
> >
> >--
> >2.33.1
> >
>