On Fri, Apr 29, 2016 at 2:15 PM, Xunlei Pang <xpang(a)redhat.com> wrote:
Besides, I would recommend "return 0" for successful
and "return 1" for failed cases, it's semantically better.
I think all the function which starts with is_ has same semantic what
has been used in this patch. For example, when
is_dump_target_configured() returns 1, it means dump target has been
used in kdump.conf. Moreover, it seems reasonable to return true(1)
when answer of question is_xxxxxxx is "yes".
Then we can have:
if ! is_crash_mem_reserved; then