Re: [PATCH] mkdumprd: Ensure kdumpbase is added

[Dave Young]

Ccing Harald.
On 10/15/20 at 06:03pm, Kairui Song wrote:
>  Dracut only check if a module failed installtion if the module is
> listed
>  in --add params. Without this param, if kdumpbase failed to install due
>  to any reason, dracut will still build the initramfs only print a
>  warning. Add this param to ensure it fail early. 
Hi Kairui,

Is this a intended behavior? It is a little odd :)

Anyway I think it is a good catch, thanks!

Acked-by: Dave Young <dyoung(a)redhat.com&gt;
 
>  
>  Signed-off-by: Kairui Song <kasong(a)redhat.com&gt;
>  ---
>   mkdumprd | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>  
>  diff --git a/mkdumprd b/mkdumprd
>  index 36f71b7..3ea1d19 100644
>  --- a/mkdumprd
>  +++ b/mkdumprd
>  @@ -17,7 +17,7 @@ SAVE_PATH=$(get_save_path)
>   OVERRIDE_RESETTABLE=0
>   
>   extra_modules=""
>  -dracut_args="--quiet --hostonly --hostonly-cmdline --hostonly-i18n --hostonly-mode
> strict -o \"plymouth dash resume ifcfg earlykdump\""
>  +dracut_args="--add kdumpbase --quiet --hostonly --hostonly-cmdline --hostonly-i18n
> --hostonly-mode strict -o \"plymouth dash resume ifcfg earlykdump\""
>   
>   readonly MKDUMPRD_TMPDIR="$(mktemp -d -t mkdumprd.XXXXXX)"
>   [ -d "$MKDUMPRD_TMPDIR" ] || perror_exit "dracut: mktemp -p -d -t
> dracut.XXXXXX failed."
>  -- 
>  2.28.0
>  _______________________________________________
>  kexec mailing list -- kexec(a)lists.fedoraproject.org
>  To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]