Re: [PATCH 0/5] kdumpctl: force rebuild when dump target is modified
Hi, Pratyush and xunlei
On 04/29/16 at 12:20pm, Pratyush Anand wrote:
Kexec-tools should be able to recognize if a dump target is
reformatted, or
dump path mounts another device.
Changes since v4:
- patch 4/5 is a new change
- patch 4/4 of V3 is now 4/5. There has been many modifications in this
patch. It includes feedback from Baoquan and Xunlei. Have also done some
modification to recognize changes related to minix and NFS filesystem as
well. Infact, whole structure of function is_fs_uuid_changed() has been
modified. Now it has been renamed as is_dump_fs_modified() to suit it
better. Although I have tested it rigorously, but still a careful review
of is_dump_fs_modified() will be helpful.
I feel we are doing too much, for example the fs type changes. Should we
really allow that especially for user specified dump targets in /etc/kdump.conf?
It is rare use cases for fs changes, maybe we should limit the support
instead of encouraging user to depends on it too much.
Ditto worries about the nfs part, thoughts?
BTW, since we support detect $dump_path fs automaticlly in the future maybe
we can drop the "fs dev" in /etc/kdump.conf, we can check the dump_path
directly
but it is another issue.
Thanks
Dave