On Thu, Aug 12, 2021 at 1:49 PM Kairui Song kasong@redhat.com wrote:
EditorConfig file is helpful for tools like `shfmt`, also could be a hint for code styling.
The code style spec used in this new added .editorconfig file is generated based on existing code style.
Following commits will make mkfadumprd, mkdumprd, kdumpctl, kdump-lib.sh, and *-module-setup.sh only be used in first kernel, so use bash syntax for these scripts. Other scripts will use sh syntax for better POSIX compatibility.
Signed-off-by: Kairui Song kasong@redhat.com
.editorconfig | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 .editorconfig
diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 00000000..52aadba3 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,32 @@ +# EditorConfig configuration for kexec-tools +# http://EditorConfig.org
+# Top-most EditorConfig file +root = true
+# Default code style for kexec-tools scripts +[*] +end_of_line = lf +shell_variant = posix +insert_final_newline = true +trim_trailing_whitespace = true +indent_style = tab +indent_size = 1 +switch_case_indent = false +function_next_line = true +binary_next_line = false +space_redirects = true
+# Some scirpts will only run with bash +[{mkfadumprd,mkdumprd,kdumpctl}] +shell_variant = bash
+# Use dracut code style for *-module-setup.sh +[*-module-setup.sh] +shell_variant = bash +indent_style = space +indent_size = 4 +switch_case_indent = true +function_next_line = false +binary_next_line = true
+space_redirects = true
It is better to have something like codestyle.txt and a requirement of shfmt in spec.
Otherwise, Acked-by: Pingfan Liu piliu@redhat.com