On Tue, Jun 16, 2020 at 3:28 PM Dave Young <dyoung(a)redhat.com> wrote:
Hi Kairui
On 06/16/20 at 01:53pm, Kairui Song wrote:
> If target is in format of UUID= or LABEL=, current code will fail as it
> expects target to be the absoluta path to the block device. Check for
> the fstype instead.
>
> Signed-off-by: Kairui Song <kasong(a)redhat.com>
> ---
> mkdumprd | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkdumprd b/mkdumprd
> index c7b8f17..3378952 100644
> --- a/mkdumprd
> +++ b/mkdumprd
> @@ -92,7 +92,7 @@ to_mount() {
>
> _mntopts="$_new_mntpoint $_fstype $_options"
> # for non-nfs _target converting to use udev persistent name
> - if [ -b "$_target" ]; then
> + if [[ "$_fstype" != *nfs ]]; then
In the same function we have "$_fstype" == "nfs"* check before this,
"nfs"* is better than *nfs since no fstype will end with nfs but with
some prefixes..
Yes, you are right, I wanted to cover nfs3/nfs4 case but used wrong
wildcard, will fix it.
> _pdev="$(get_kdump_persistent_dev $_target)"
> if [ -z "$_pdev" ]; then
> return 1
> --
> 2.26.2
> _______________________________________________
> kexec mailing list -- kexec(a)lists.fedoraproject.org
> To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
Thanks
Dave
--
Best Regards,
Kairui Song