Re: [PATCH] kdump.sysconfig: Remove the option 'log_buf_len' from kdump command line

[piliu]

On 05/22/2020 02:45 PM, Lianbo Jiang wrote:
>  The option 'log_buf_len' in the kernel command line will make
> kernel
>  dynamically allocate memory (system ram) from memblock and always hold
>  the memory allocated. If the size of this option is misused such as
>  'log_buf_len=64M'. This may cause a short of memory for kdump kernel,
>  because the size of memory is usually limited in kdump kernel.
>  
>  In order to avoid this problem, need to remove this option from the
>  kdump kernel command line.
>  
>  Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com&gt;
>  ---
>   kdump.sysconfig         | 2 +-
>   kdump.sysconfig.aarch64 | 2 +-
>   kdump.sysconfig.i386    | 2 +-
>   kdump.sysconfig.ppc64   | 2 +-
>   kdump.sysconfig.ppc64le | 2 +-
>   kdump.sysconfig.s390x   | 2 +-
>   kdump.sysconfig.x86_64  | 2 +-
>   7 files changed, 7 insertions(+), 7 deletions(-)
>  
>  diff --git a/kdump.sysconfig b/kdump.sysconfig
>  index df518d64afd8..7c5641a6d8ac 100644
>  --- a/kdump.sysconfig
>  +++ b/kdump.sysconfig
>  @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE=""
>   # This variable lets us remove arguments from the current kdump commandline
>   # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
>   # NOTE: some arguments such as crashkernel will always be removed
>  -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet"
>  +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len"
>   
>   # This variable lets us append arguments to the current kdump commandline
>   # after processed by KDUMP_COMMANDLINE_REMOVE
>  diff --git a/kdump.sysconfig.aarch64 b/kdump.sysconfig.aarch64
>  index d5d762436eca..cbe611869e65 100644
>  --- a/kdump.sysconfig.aarch64
>  +++ b/kdump.sysconfig.aarch64
>  @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE=""
>   # This variable lets us remove arguments from the current kdump commandline
>   # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
>   # NOTE: some arguments such as crashkernel will always be removed
>  -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet"
>  +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len"
>   
>   # This variable lets us append arguments to the current kdump commandline
>   # after processed by KDUMP_COMMANDLINE_REMOVE
>  diff --git a/kdump.sysconfig.i386 b/kdump.sysconfig.i386
>  index c31a8cbe3077..61d940718c66 100644
>  --- a/kdump.sysconfig.i386
>  +++ b/kdump.sysconfig.i386
>  @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE=""
>   # This variable lets us remove arguments from the current kdump commandline
>   # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
>   # NOTE: some arguments such as crashkernel will always be removed
>  -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet"
>  +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len"
>   
>   # This variable lets us append arguments to the current kdump commandline
>   # after processed by KDUMP_COMMANDLINE_REMOVE
>  diff --git a/kdump.sysconfig.ppc64 b/kdump.sysconfig.ppc64
>  index 1f954521fd6d..6c091a74a74f 100644
>  --- a/kdump.sysconfig.ppc64
>  +++ b/kdump.sysconfig.ppc64
>  @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE=""
>   # This variable lets us remove arguments from the current kdump commandline
>   # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
>   # NOTE: some arguments such as crashkernel will always be removed
>  -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet"
>  +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len"
>   
>   # This variable lets us append arguments to the current kdump commandline
>   # after processed by KDUMP_COMMANDLINE_REMOVE
>  diff --git a/kdump.sysconfig.ppc64le b/kdump.sysconfig.ppc64le
>  index 1f954521fd6d..6c091a74a74f 100644
>  --- a/kdump.sysconfig.ppc64le
>  +++ b/kdump.sysconfig.ppc64le
>  @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE=""
>   # This variable lets us remove arguments from the current kdump commandline
>   # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
>   # NOTE: some arguments such as crashkernel will always be removed
>  -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet"
>  +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len"
>   
>   # This variable lets us append arguments to the current kdump commandline
>   # after processed by KDUMP_COMMANDLINE_REMOVE
>  diff --git a/kdump.sysconfig.s390x b/kdump.sysconfig.s390x
>  index abd45a2f332d..958eb8f24ca3 100644
>  --- a/kdump.sysconfig.s390x
>  +++ b/kdump.sysconfig.s390x
>  @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE=""
>   # This variable lets us remove arguments from the current kdump commandline
>   # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
>   # NOTE: some arguments such as crashkernel will always be removed
>  -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet"
>  +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len"
>   
>   # This variable lets us append arguments to the current kdump commandline
>   # after processed by KDUMP_COMMANDLINE_REMOVE
>  diff --git a/kdump.sysconfig.x86_64 b/kdump.sysconfig.x86_64
>  index a43a97062500..95a26a4d0833 100644
>  --- a/kdump.sysconfig.x86_64
>  +++ b/kdump.sysconfig.x86_64
>  @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE=""
>   # This variable lets us remove arguments from the current kdump commandline
>   # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline
>   # NOTE: some arguments such as crashkernel will always be removed
>  -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet"
>  +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug quiet log_buf_len"
>   
>   # This variable lets us append arguments to the current kdump commandline
>   # after processed by KDUMP_COMMANDLINE_REMOVE
>   
Acked-by: Pingfan Liu <piliu(a)redhat.com&gt;