Re: [PATCH] Clear old crashkernl=auto in comment and doc

[Pingfan Liu]

On Fri, Jul 30, 2021 at 2:43 PM Kairui Song <kasong(a)redhat.com&gt; wrote:
>  Signed-off-by: Kairui Song <kasong(a)redhat.com&gt;
>  ---
>   fadump-howto.txt | 9 ++++++---
>   kdumpctl         | 2 +-
>   2 files changed, 7 insertions(+), 4 deletions(-)
>
>  diff --git a/fadump-howto.txt b/fadump-howto.txt
>  index 433e9a6..bc87644 100644
>  --- a/fadump-howto.txt
>  +++ b/fadump-howto.txt
>  @@ -344,9 +344,12 @@ or
>   OR
>      # grubby --update-kernel=/boot/vmlinuz-`uname -r` --args="fadump=off"
>
>  -If KDump is to be used as the dump capturing mechanism, update the crashkernel
>  -parameter (Else, remove "crashkernel=" parameter too, using grubby):
>  +Remove "crashkernel=" from kernel cmdline parameters:
>
>  -   # grubby --update-kernel=/boot/vmlinuz-$kver --args="crashkernl=auto"
>  +   # grubby --update-kernel=/boot/vmlinuz-`uname -r`
> --remove-args="crashkernel"
>  +
>  +If KDump is to be used as the dump capturing mechanism, reset the crashkernel
> parameter:
>  +
>  +   # kdumpctl reset-crashkernel `uname -r`
>
>   Reboot the system for the settings to take effect.
>  diff --git a/kdumpctl b/kdumpctl
>  index 0fb73b6..f10b091 100755
>  --- a/kdumpctl
>  +++ b/kdumpctl
>  @@ -1232,7 +1232,7 @@ do_estimate()
>                  baseline=$((${baseline%Y} * 1048576))
>          fi
>
>  -       # The default value when using crashkernel=auto
>  +       # The default pre-reserved crashkernel value
>          baseline_size=$((baseline * size_mb))
>          # Current reserved crashkernel size
>          reserved_size=$(cat /sys/kernel/kexec_crash_size)
>  -- 
Acked-by: Pingfan Liu <piliu(a)redhat.com&gt;