On 08/30/2017 at 10:12 AM, Xunlei Pang wrote:
With the help of dracut "--no-hostonly-default-device", we can have only one device being recognized (dump target) in most cases under kdump.
Now that we use a different(simpler and better) approach, it's time to revert the old approach(Patch 1~4).
This patch series has passed my tests about LUKS, iscsi, lvm, nfs, etc.
Xunlei Pang (8): Revert "mkdumprd: omit dracut modules in case of network dumping" Revert "mkdumprd: omit dracut modules in case of no dm target" Revert "mkdumprd: omit crypt when there is no crypt kdump target" Revert "kdumpctl: use generated rd.lvm.lv=X" kdumpctl: move is_fadump_capable() to kdump-lib.sh mkdumprd: apply dracut "--hostonly-cmdline" and "--no-hostonly-default-device" kdumpctl: remove some cmdline inheritage from 1st kernel module-setup: remove software iscsi cmdline generated by dracut
For better understanding, here is the improved changelog: Dracut has "--hostonly-cmdline" which can generate cmdlines(if any) regarding the dump target, it's an existing way for us to use to simplifa the code. E.g. We can remove generate_lvm_cmdlines() if we use "--hostonly-cmdline".
But "--hostonly-cmdline" has other issues(e.g. BZ1451717), it adds needless devices for kdump like root device. These issues can be solved with the help of dracut "--no-hostonly-default-device", we can have only one device being recognized (dump target) in most cases under kdump.
This patch series applies dracut's "--hostonly-cmdline" together with "--no-hostonly-default-device", and removes some old code accordingly.
Please "man dracut.cmdline" for "--hostonly-cmdline", "--no-hostonly-default-device" details.
Also see "--no-hostonly-default-device" patches: https://github.com/dracutdevs/dracut/pull/269
Has passed tests about LUKS, iscsi, lvm, nfs, etc.
dracut-module-setup.sh | 5 +++++ kdump-lib.sh | 25 +++++++++++---------- kdumpctl | 56 +++++++--------------------------------------- mkdumprd | 60 +++++++------------------------------------------- 4 files changed, 34 insertions(+), 112 deletions(-)