Re: [PATCH 0/2] generalize kdump-gen-sysconfig

[Philipp Rudo]

Hi Kairui,

On Tue, 26 Apr 2022 22:38:34 +0800
Kairui Song <ryncsn(a)gmail.com&gt; wrote:

>  Philipp Rudo <prudo(a)redhat.com&gt; 于2022年4月26日周二 21:58写道：
>  
>  >
>  > Hi Kairui,
>  >
>  > we just got a request from IBM to use zlib compression with makedumpfile for
>  > s390 but we don't want to change it for all architectures. So I thought your
>  > approach should work for kdump.conf as well. That's why I took the liberty to
>  > generalize your kdump-gen-sysconfig. What do you think?  
>  
>  Looks great :) 
Thanks!

>  >
>  > FYI, it's only a quick and dirty implementation and I haven't properly
> tested
>  > it yet.  
>  
>  Seems this based on the previous kdump-gen-configs V1 patch? I just
>  replied to some of your comments, please have a look and I'll update
>  V2. 
yes, it's based on your v1. Sorry, should have mentioned it...

Thanks
Philipp

>  
>  >
>  > Thanks
>  > Philipp
>  >
>  > Philipp Rudo (2):
>  >   kdump-gen-configs: emphasize differences from default instead of
>  >     overwriting it
>  >   kdump-gen-configs: make generic and set core_collector for s390
>  >
>  >  .gitignore                        |  2 +
>  >  kdump-gen-configs.sh              | 73 +++++++++++++++++++++++++++++++
>  >  kdump-gen-sysconfig.sh            | 51 ---------------------
>  >  kdump.conf => kdump.conf.template |  0
>  >  kdump.sysconfig.template          |  4 +-
>  >  kexec-tools.spec                  |  6 +--
>  >  6 files changed, 80 insertions(+), 56 deletions(-)
>  >  create mode 100755 kdump-gen-configs.sh
>  >  delete mode 100755 kdump-gen-sysconfig.sh
>  >  rename kdump.conf => kdump.conf.template (100%)
>  >
>  > --
>  > 2.35.1
>  >  
>