Re: [PATCH] s390x: do not install /etc/adjtime

[WANG Chao]

On 02/27/14 at 12:41pm, Dave Young wrote:
> On 02/26/14 at 02:21pm, WANG Chao wrote:
> > On s390x, RTC or hardware clock doesn't exist. So we don't need
> > /etc/adjtime to adjust time to UTC or localtime.
> >
> > AFAIK, s390 uses a more precise time source which is storing time in
> > UTC. But we still need /etc/localtime to determine the system-wide time
> > zone.
> > Signed-off-by: WANG Chao
> >
> > dracut-module-setup.sh | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> > index 4e7d5dc..37a5fa5 100755
> > --- a/dracut-module-setup.sh
> > +++ b/dracut-module-setup.sh
> > @@ -460,6 +460,16 @@ kdump_install_random_seed() {
> >         bs=$poolsize count=1 2> /dev/null
> >  }
> >
> > +# /etc/adjtime is used to determine RTC time format (UTC or localtime)
> > +# /etc/localtime is used to set system timezone
> > +kdump_install_time() {
> > # RTC doesn't exist on s390
> > if [ `uname -m` != "s390x" ]; then
> >    dracut_install -o /etc/adjtime
>
> The problem is why there's no problem in 1st kernel with same /etc/adjtime
> It looks more like systemd issue to me. It should be always UTC if local
> time make no sense in s390...

That's because chrony (ntp) sync the time in 1st kernel to the right time.

I think /etc/adjtime shouldn't exist or at least adjtime file should
contain UTC rather than LOCAL in case of s390. I've filed bz1070748 for
anaconda. You can find more details there.

I think we can hold off this patch review and wait some response from
anaconda team and Hendrik.

Thanks
WANG Chao
> > fi
> > dracut_install -o /etc/localtime
> >
> > +}
> >
> > install() {
> >      kdump_install_conf
> >      >"$initdir/lib/dracut/no-emergency-shell"
> > @@ -467,7 +477,7 @@ install() {
> >      if is_ssh_dump_target; then
> >          kdump_install_random_seed
> >      fi
> > dracut_install -o /etc/adjtime /etc/localtime
> > kdump_install_time
> > inst "$moddir/monitor_dd_progress" "/kdumpscripts/monitor_dd_progress"
> > chmod +x ${initdir}/kdumpscripts/monitor_dd_progress
> > inst "/bin/dd" "/bin/dd"
> >
> > -- 
> > 1.8.5.3
> >
> > kexec mailing list
> > [e-mail]
> > https://lists.fedoraproject.org/mailman/listinfo/kexec