On 03/28/2017 at 05:55 PM, Baoquan He wrote:
On 03/28/17 at 05:22pm, Xunlei Pang wrote:
> On 03/28/2017 at 05:08 PM, Baoquan He wrote:
>> On 03/28/17 at 05:03pm, Xunlei Pang wrote:
>>> On 03/28/2017 at 04:05 PM, Baoquan He wrote:
>>>>> @@ -120,7 +120,7 @@ to_mount() {
>>>>> # If remote mount fails, dracut-initqueue will still start and
once
>>>>> # dracut-initqueue finishes, kdump service will start. Because
remote mount
>>>>> # failed, kdump service will fail and it will lead to kdump
error handler.
>>>>> - if ! is_nfs_dump_target; then
>>>>> + if ! is_fs_type_nfs $_fstype; then
>>>> This sounds reasonable. But one question comes up, checking fedora git
>>>> log, I found commit about this code adding was merged earlier than the
From the fedora git log:
commit 002337c6715e442f306b87b92340bef15c4420ac
Author: WANG Chao <chaowang(a)redhat.com>
Date: Thu May 8 19:37:15 2014 +0800
Introduce kdump error handling service
commit de95c74a76aa515f8e1baf5e5decdefd8ec4a81b
Author: WANG Chao <chaowang(a)redhat.com>
Date: Mon Jun 16 16:57:21 2014 +0800
mkdumprd: append "x-initrd.mount" to the mount options.
So, "x-initrd.mount" change is after "kdump error handling service".
>>>> commit de95c74 ("mkdumprd: append
"x-initrd.mount" to the mount options.").
>>>>
>>>> May I assume since commit de95c74 has been added, x-initrd.mount adding
>>>> is not needed anymore?
>> Seems I copied the wrong commit. I mean this one:
>> 002337c Introduce kdump error handling service
> They should be different issues, this one is related to local-fs.target or
remote-fs.target,
> according to the comments, if we add x-initrd.mount, it will be regarded as
local-fs.target
> related other than remote-fs.target. Systemd handles the two targets in different
ways.
See this paragraph in git log. Add x-initrd.mount just because emergency
service is triggered in non isolate mode, at that time kdump isolate
service has not been added yet, I believe. So with kdump isolate service
added, any mount failure will trigger isolate kdump error handler, does
it really have chance to care if it's x-initrd.mount added or not?
Now when mount in /etc/fstab fails, systemd would not consider it as
critical and it would continue to boot. In fact, emergency service is
triggered, but not in a isolation mode, and it results in the emergency
service getting shutdown at some point later of the boot process. We
need isolation otherwise we won't see any emergency service.
Yes, I got your point this time. But things have changed until now, for example,
the changelog says "From systemd unit point of view,
"initrd-root-fs.target" has
OnFailureIsolate=yes, but "local-fs.target" doesn't", but on the
current Fedora,
both of them haven't.
Regards,
Xunlei
> Anyway, for nfs dumping using "nfs" directive or just mounted to the save
path should
> make no difference.