Oops,
set default value before sourcing sysconfig will be the right way.
sent from mobile phone,sorry for the format problem
Thanks
Dave
----- Original Message -----
From: Dave Young <dyoung(a)redhat.com>
To: Dangyi Liu <dliu(a)redhat.com>
Cc: kexec(a)lists.fedoraproject.org, Baoquan He <bhe(a)redhat.com>
Sent: Fri, 04 Dec 2015 04:27:17 -0500 (EST)
Subject: Re: [PATCH v3] kdump.sysconfig: add KDUMP_COMMANDLINE_REMOVE
On 11/18/15 at 04:00pm, Dangyi Liu wrote:
[snip]
# Any additional kexec arguments required. In most situations, this
should
diff --git a/kdumpctl b/kdumpctl
index 9f7e56b..ef18a2d 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -19,6 +19,9 @@ DEFAULT_DUMP_MODE="kdump"
standard_kexec_args="-p"
+# Some default values in case /etc/sysconfig/kdump doesn't include
+KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug"
+
sysconfig file was sourced earlier so this variable is overwriting here
should be replace by like below
[ -z $KDUMP_COMMANDLINE_REMOVE ] && KDUMP_COMMANDLINE_REMOVE="hugepages
hugepagesz slub_debug"
Since Dangyi left I will take it and repost.
Thanks
Dave
_______________________________________________
kexec mailing list
kexec(a)lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/kexec@lists.fedoraproject.org